Signed-off-by: Chenxiong Qi cqi@redhat.com
I think in case of Fedora dist-git the pkgs component should remain in the URL.
pkgs
This is current URL: https://src.fedoraproject.org/repo/pkgs/compose-utils/compose-utils-0.1.16.tar.bz2/sha512/…/compose-utils-0.1.16.tar.bz2.
https://src.fedoraproject.org/repo/pkgs/compose-utils/compose-utils-0.1.16.tar.bz2/sha512/…/compose-utils-0.1.16.tar.bz2
If the pkgs path is removed, I'm getting 404, but https://src.fedoraproject.org/repo/pkgs/rpms/compose-utils/compose-utils-0.1.16.tar.bz2/sha512/…/compose-utils-0.1.16.tar.bz2 works.
https://src.fedoraproject.org/repo/pkgs/rpms/compose-utils/compose-utils-0.1.16.tar.bz2/sha512/…/compose-utils-0.1.16.tar.bz2
There's one .swp file included in the PR.
.swp
Also there is a problem with the tests: the ones for the namespace expect .git/config file, but it's missing. I updated the rhpkg-simple patch to include those.
.git/config
rebased onto a31f07dd46de74e3067c2c9cc4675ae4d2e1dd52
rebased onto e841a3b13293a629b093f6546f0e674e77090ee6
@lsedlar Fixed above issues. PTAL.
URL looks correct and sources for package in rpms namespace can be downloaded. The tests still don't pass for me:
rpms
$ ./tests/run-tests.sh test_md5_bsd 0K test_md5_old 0K test_ns_pkgname FAIL DIFF: --- expected 2017-09-25 14:34:58.473644723 +0200 +++ /tmp/tmp.ipXfesx1Mj 2017-09-25 14:37:01.089631624 +0200 @@ -1,2 +1,2 @@ -curl -L -H Pragma: -o ./github-linguist-4.8.18.gem -R -S --fail --retry 5 --max-time 15 https://src.fedoraproject.org/repo/pkgs/container/fedpkg-minimal/github-linguist-4.8.18.gem/sha512/d556ffe0062bc2c745c46e94929eab18c79fd221ffc1dd0c0ea5868428bd130d7b15eec618e9c3940b50c27559923911135770792864f3330a606132dc8819c0/github-linguist-4.8.18.gem +curl -L -H Pragma: -o ./github-linguist-4.8.18.gem -R -S --fail --retry 5 --max-time 15 https://src.fedoraproject.org/repo/pkgs/rpms/test_ns_pkgname/github-linguist-4.8.18.gem/sha512/d556ffe0062bc2c745c46e94929eab18c79fd221ffc1dd0c0ea5868428bd130d7b15eec618e9c3940b50c27559923911135770792864f3330a606132dc8819c0/github-linguist-4.8.18.gem sha512sum -c sources test_sha512_bsd 0K
2 new commits added
Similar method is used. Now, git/config is included and copied to .git when run test. This time it should work.
.git
Now the tests pass for me. I think this approach works, so :thumbsup: from me. Maybe it would be nice to get someone else to review as well, just to be sure.
This doesn't work if the URL does not end with .git.
Apparently I'm wrong and this is not a problem.
Is this pr still useful? Do we need to keep it opening or just close it?
I'm actually not sure. As far as I know, there was no one on Fedora side asking for lookaside in different namespaces, and so this is probably not really needed.
Yeah, I think we don't have plans for this, so I am going to just close it.
Feel free to file a new one if there's a need.
:information_source:
Pull-Request has been closed by kevin
Signed-off-by: Chenxiong Qi cqi@redhat.com