fedora-zuul-jobs

#127 Rename 'rpm-test' job to 'rpm-sti-test'
Merged by zuul. Opened by guyinger.
guyinger/fedora-zuul-jobs rename_rpm_test_to_rpm_sti_test  into  master

Download 127.patch

Rename the job so it's consistent with the naming in Zuul CentOS CI environment.

Depends-on: https://pagure.io/fedora-zuul-jobs-config/pull-request/142

Zuul encountered a syntax error while parsing its configuration in the
repo fedora-zuul-jobs on branch master. The error was:

Job rpm-sti-test in fedora-zuul-jobs is not permitted to shadow job rpm-sti-test in fedora-zuul-jobs-config

The error appears in the following job stanza:

job:
name: rpm-sti-test
description: "Install the built rpms and run STI tests (rawhide variant)"
run: playbooks/rpm/rpmtest.yaml
post-run:
- playbooks/rpm/rpmtest-fetch-artifacts.yaml
branches:
- rawhide
- main
nodeset: fedora-rawhide-vm-medium
requires:
- repo
roles:
- zuul: zuul-distro-jobs
timeout: 18000
vars:
repos:
- name: distro-build
url: https://kojipkgs.fedoraproject.org/repos/rawhide/latest/x86_64/

in "fedora-zuul-jobs/zuul.d/jobs.yaml@master", line 86, column 3

I'd like we move forward with that change step by step:
1/ Define a check-for-sti-tests job (in fedora-zuul-jobs-config)
2/ in templates (in fedora-zuul-jobs) add in test template (step 2 and 3 could be done in one PR) : 

        - check-for-sti-tests:
            dependencies:
              - rpm-scratch-build

3/ in templates (in fedora-zuul-jobs) add in test template : 

        - rpm-sti-test:
            dependencies:
              - check-for-sti-tests
              - rpm-scratch-build

4/ In templates (in fedora-zuul-jobs) remove the dependency "check-for-tests" to the rpm-install-test job
5/ In jobs (in fedora-zuul-jobs-config) remove check-for-test job and related playbook
6/ In jobs (in fedora-zuul-jobs) remove rpm-test job and related playbook

+1 on @fbo comments, let's follow his advice here @guyinger

rebased onto e29a1a8151cc4c1050276dd223b6d543cb4e2acd

Zuul encountered a syntax error while parsing its configuration in the
repo fedora-zuul-jobs on branch master. The error was:

Job rpm-sti-test in fedora-zuul-jobs is not permitted to shadow job rpm-sti-test in fedora-zuul-jobs-config

The error appears in the following job stanza:

job:
name: rpm-sti-test
description: Run STI test on Testing Farm
run: playbooks/testing-farm/run.yaml
branches:
- rawhide
- main
nodeset: fedora-rawhide-vm-medium
requires:
- repo
roles:
- zuul: zuul-distro-jobs
timeout: 18000
vars:
repos:
- name: distro-build
url: https://kojipkgs.fedoraproject.org/repos/rawhide/latest/x86_64/

in "fedora-zuul-jobs/zuul.d/jobs.yaml@master", line 86, column 3

I'd like we move forward with that change step by step:
1/ Define a check-for-sti-tests job (in fedora-zuul-jobs-config)
2/ in templates (in fedora-zuul-jobs) add in test template (step 2 and 3 could be done in one PR) :
- check-for-sti-tests: dependencies: - rpm-scratch-build
3/ in templates (in fedora-zuul-jobs) add in test template :
- rpm-sti-test: dependencies: - check-for-sti-tests - rpm-scratch-build
4/ In templates (in fedora-zuul-jobs) remove the dependency "check-for-tests" to the rpm-install-test job
5/ In jobs (in fedora-zuul-jobs-config) remove check-for-test job and related playbook
6/ In jobs (in fedora-zuul-jobs) remove rpm-test job and related playbook

Changes apply in this current PR and in https://pagure.io/fedora-zuul-jobs-config/pull-request/142#

@fbo I removed this since it didn't seem needed. is it OK?

In this PR, let's do step 2 and 3 only and please keep rpm-test in job and template (we'll remove it later in step 5 and 6).

rebased onto ae5cb294c5e9046a35e946559e8f8a6f50ae2c78

Zuul encountered a syntax error while parsing its configuration in the
repo fedora-zuul-jobs on branch master. The error was:

Job check-for-sti-tests not defined

The error appears in the following project-template stanza:

project-template:
name: test
check:
jobs:
- check-for-sti-tests:
dependencies:
- rpm-scratch-build
- check-for-fmf-tests:
dependencies:
- rpm-scratch-build
- rpm-install-test:
dependencies:
- rpm-scratch-build
- rpm-sti-test:
dependencies:
- check-for-sti-tests
- rpm-scratch-build
- rpm-tmt-test:
dependencies:
- check-for-fmf-tests
- rpm-scratch-build

in "fedora-zuul-jobs/zuul.d/templates.yaml@master", line 32, column 3

rebased onto b97227fa8e1cdaff8b3c9c7096d9823776d23cc8

Zuul encountered a syntax error while parsing its configuration in the
repo fedora-zuul-jobs on branch master. The error was:

Job check-for-sti-tests not defined

The error appears in the following project-template stanza:

project-template:
name: test
check:
jobs:
- check-for-tests:
dependencies:
- rpm-scratch-build
- check-for-sti-tests:
dependencies:
- rpm-scratch-build
- check-for-fmf-tests:
dependencies:
- rpm-scratch-build
- rpm-install-test:
dependencies:
- check-for-tests
- rpm-scratch-build
- rpm-test:
dependencies:
- check-for-tests
- rpm-scratch-build
- rpm-tmt-test:
dependencies:
- check-for-fmf-tests
- rpm-scratch-build
- rpm-sti-test:
dependencies:
- check-for-sti-tests
- rpm-scratch-build

in "fedora-zuul-jobs/zuul.d/templates.yaml@master", line 32, column 3

Done. I think later we could also remove check-for-tests and rpm-test - it seems identical to the jobs added on steps 2 & 3.

@guyinger well, zuul says it is not ok :) is it wrong? :)

Maybe adding Depends-on: https://pagure.io/fedora-zuul-jobs-config/pull-request/142 would help? :)

Zuul encountered a syntax error while parsing its configuration in the
repo fedora-zuul-jobs on branch master. The error was:

Job check-for-sti-tests not defined

The error appears in the following project-template stanza:

project-template:
name: test
check:
jobs:
- check-for-tests:
dependencies:
- rpm-scratch-build
- check-for-sti-tests:
dependencies:
- rpm-scratch-build
- check-for-fmf-tests:
dependencies:
- rpm-scratch-build
- rpm-install-test:
dependencies:
- check-for-tests
- rpm-scratch-build
- rpm-test:
dependencies:
- check-for-tests
- rpm-scratch-build
- rpm-tmt-test:
dependencies:
- check-for-fmf-tests
- rpm-scratch-build
- rpm-sti-test:
dependencies:
- check-for-sti-tests
- rpm-scratch-build

in "fedora-zuul-jobs/zuul.d/templates.yaml@master", line 32, column 3

Zuul encountered a syntax error while parsing its configuration in the
repo fedora-zuul-jobs on branch master. The error was:

Job check-for-sti-tests not defined

The error appears in the following project-template stanza:

project-template:
name: test
check:
jobs:
- check-for-tests:
dependencies:
- rpm-scratch-build
- check-for-sti-tests:
dependencies:
- rpm-scratch-build
- check-for-fmf-tests:
dependencies:
- rpm-scratch-build
- rpm-install-test:
dependencies:
- check-for-tests
- rpm-scratch-build
- rpm-test:
dependencies:
- check-for-tests
- rpm-scratch-build
- rpm-tmt-test:
dependencies:
- check-for-fmf-tests
- rpm-scratch-build
- rpm-sti-test:
dependencies:
- check-for-sti-tests
- rpm-scratch-build

in "fedora-zuul-jobs/zuul.d/templates.yaml@master", line 32, column 3

rebased onto b683c9c7e4d9fe4c0e7e5558e4cea26183579826

Zuul encountered a syntax error while parsing its configuration in the
repo fedora-zuul-jobs on branch master. The error was:

Job check-for-sti-tests not defined

The error appears in the following project-template stanza:

project-template:
name: test
check:
jobs:
- check-for-tests:
dependencies:
- rpm-scratch-build
- check-for-sti-tests:
dependencies:
- rpm-scratch-build
- check-for-fmf-tests:
dependencies:
- rpm-scratch-build
- rpm-install-test:
dependencies:
- check-for-tests
- rpm-scratch-build
- rpm-test:
dependencies:
- check-for-tests
- rpm-scratch-build
- rpm-tmt-test:
dependencies:
- check-for-fmf-tests
- rpm-scratch-build
- rpm-sti-test:
dependencies:
- check-for-sti-tests
- rpm-scratch-build

in "fedora-zuul-jobs/zuul.d/templates.yaml@master", line 32, column 3

rebased onto 5f7fd4464dfc18bb509cc1049508dc658863c522

Zuul encountered a syntax error while parsing its configuration in the
repo fedora-zuul-jobs on branch master. The error was:

Job check-for-sti-tests not defined

The error appears in the following project-template stanza:

project-template:
name: test
check:
jobs:
- check-for-tests:
dependencies:
- rpm-scratch-build
- check-for-sti-tests:
dependencies:
- rpm-scratch-build
- check-for-fmf-tests:
dependencies:
- rpm-scratch-build
- rpm-install-test:
dependencies:
- check-for-tests
- rpm-scratch-build
- rpm-test:
dependencies:
- check-for-tests
- rpm-scratch-build
- rpm-tmt-test:
dependencies:
- check-for-fmf-tests
- rpm-scratch-build
- rpm-sti-test:
dependencies:
- check-for-sti-tests
- rpm-scratch-build

in "fedora-zuul-jobs/zuul.d/templates.yaml@master", line 32, column 3

Done. I think later we could also remove check-for-tests and rpm-test - it seems identical to the jobs added on steps 2 & 3.

yes that's step 5 and 6.

Maybe adding Depends-on: https://pagure.io/fedora-zuul-jobs-config/pull-request/142 would help? :)

No, depends-on do not work with a "config" repository for security reason. So unfortunately in this context we cannot benefit from it. Here the depends-on will just prevent Zuul to merge this patch if 142 is not merged. Anyway 142 looks good I'll merge it.

recheck

Build succeeded.

Metadata Update from @fbo:
- Pull-request tagged with: gateit

Build succeeded (gate pipeline).

Pull-Request has been merged by zuul
Metadata
None

gateit

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.