fedora-websites

#847 Fix atomic download urls with updated twoweek fedmsg structure
Merged by dustymabe. Opened by sinnykumari.
sinnykumari/fedora-websites master  into  master

Download 847.patch

With releng PR - https://pagure.io/releng/pull-request/7519
, next Atomic twoweek release fedmsg will have updated
structure of message to accommodate multi-arch content.

Signed-off-by: Sinny Kumari sinny@redhat.com

This PR is for review only.
It can be merged once we do next Atomic Two Week release successfully with multi-arch content included in fedmsg org.fedoraproject.prod.releng.atomic.twoweek.complete.

One of the atomic team member will let know when it is ok to merge.

LGTM. We'll merge this right after we do the next atomic release?

LGTM. We'll merge this right after we do the next atomic release?

Yes, otherwise getfedora website build will break as well.
Edited by sinnykumari

since the release is out and the website is broken without this PR I'm going to go ahead and merge.

Pull-Request has been merged by dustymabe

so when I ran this locally after the release happened it worked fine (i was able to see AMIs and all) - after merging this PR the website does not show AMIs on the atomic page. Maybe there is a cache that needs to be refreshed?

There's a traceback from the site build cron job: 

INFO:atomic_vars:Looking for latest atomic release for 28
Traceback (most recent call last):
  File "/srv/web/fedora-websites/getfedora.org/../build.d/build.py", line 274, in <module>
    main()
  File "/srv/web/fedora-websites/getfedora.org/../build.d/build.py", line 271, in main
    process(args)
  File "/srv/web/fedora-websites/getfedora.org/../build.d/build.py", line 118, in process
    process_dir(dirpath, filenames)
  File "/srv/web/fedora-websites/getfedora.org/../build.d/build.py", line 161, in process_dir
    globalvar.release['next_atomic_id'],
  File "/usr/lib/python2.7/site-packages/dogpile/cache/region.py", line 1053, in decorate
    should_cache_fn)
  File "/usr/lib/python2.7/site-packages/dogpile/cache/region.py", line 657, in get_or_create
    async_creator) as value:
  File "/usr/lib/python2.7/site-packages/dogpile/core/dogpile.py", line 158, in __enter__
    return self._enter()
  File "/usr/lib/python2.7/site-packages/dogpile/core/dogpile.py", line 98, in _enter
    generated = self._enter_create(createdtime)
  File "/usr/lib/python2.7/site-packages/dogpile/core/dogpile.py", line 149, in _enter_create
    created = self.creator()
  File "/usr/lib/python2.7/site-packages/dogpile/cache/region.py", line 625, in gen_value
    created_value = creator()
  File "/usr/lib/python2.7/site-packages/dogpile/cache/region.py", line 1049, in creator
    return fn(*arg, **kw)
  File "build/atomic_vars.py", line 148, in collect
    image_name = message['msg']['atomic_qcow2']['image_name']
KeyError: 'atomic_qcow2'
make: *** [af] Error 1

getfedora from master builds fine for me as well on local machine. AMIs and image downloads links looks correct.

@kevin from error log mentioned above:

File "build/atomic_vars.py", line 148, in collect
image_name = message['msg']['atomic_qcow2']['image_name']

It certainly looks to me a caching issue because if we look at build/atomic_vars.py, line 148 in master, we have

image_name = message['msg']['x86_64']['atomic_qcow2']['image_name']

Any idea whom to ask for cleaning the cache and rebuild getfedora website on prod?

looks good now. must have re-deployed itself :)

Can anyone cherry-pic this to stg too? We are on the f28 branch there...

Can anyone cherry-pic this to stg too? We are on the f28 branch there...

done

Thanks @dustymabe

Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.