#545 HTML tags' lang attribute should be assigned according current locale setting
Closed: Fixed Opened by mariosant.

Code from layout:

{{{

}}} The lang attribute should be set according the current locale.

I have a commit that fixes that but I am not sure how to submit it. Could you please point me to docs?

You can attach the patch here and I'll merge it in. Generate it with something like:

git format-patch --stdout HEAD^

(Note to committers: If someone merges it before I get to it, please ensure credit is retained in the git log. Thanks.)

Before speaking about merging let's verify it and try it in staging. I'm not sure this is needed, and it also interests other websites, not only getfedora.

This is responsible for localizing issues like the one demonstrated at http://ibin.co/24jtpZmkeiKE . In case you don't know greek, the punctuation is wrong and it can be fixed in modern browsers, by assigning the lang attribute correctly.

I believe it will also provide better accessibility (screen readers will understand the language, etc) as well.

attachment
patch

Ok, I ran a sed against our getfedora tree in staging, it should show up in about 75 minutes from now. Could you please test it in our staging instance and tell us if it resolves your issue? Sorry but I don't speak greek, but locally I can see a slight difference though.

https://stg.getfedora.org/

If yes we can merge it into production and apply it also to the other websites we are running.
Thank you.

Yup, it's fixed!

You can check the footer of https://stg.getfedora.org/el and compare it with https://getfedora.org/el .

I am SO GLAD to finally fix that!

Great! Thanks for testing it.

Fix pushed to production for all new websites:
* getfedora.org
* arm.fedoraproject.org
* labs.fedoraproject.org
* spins.fedoraproject.org

Just need some translating now ;)

Metadata