fedora-sig-onboard

#1 Miscelaneous minor fixes
Merged by dcavalca. Opened by gotmax23.
gotmax23/fedora-sig-onboard main  into  main

Download 1.patch

I saw your message on devel@ and figured I'd try to help implement better error handling and make it less "hacky." Hopefully, I succeeded! I did my best to split this up into separate commits so it was easier to review and you could cherry-pick the parts that you liked.

6 new commits added

  • Onboarder: Import better error handling and fallback
  • Add --acl option.
  • Raise ClickException's instead of generic ones
  • Remove shebang and executable bit from cli.py
  • Add installation instructions
  • Fix typo in the README

https://pagure.io/fork/gotmax23/fedora-sig-onboard/blob/a4945088d78e0b8db9d937cf5a741bca8100341b/f/fedora_sig_onboard/onboarder.py#_23 also seems unnecessary to me, because the existence of the config path is already checked in cli.py.

This looks all great, thanks!

https://pagure.io/fork/gotmax23/fedora-sig-onboard/blob/a4945088d78e0b8db9d937cf5a741bca8100341b/f/fedora_sig_onboard/onboarder.py#_23 also seems unnecessary to me, because the existence of the config path is already checked in cli.py.

Yeah, I wrote it that was on the assumption that one could import the module in some other Python tool and attempt to use it without the CLI, but it's probably unnecessary.

Pull-Request has been merged by dcavalca
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.