From afced8d93eee1061aaaab0d296e4648f69b567bb Mon Sep 17 00:00:00 2001 From: Queen Date: Apr 02 2021 18:22:18 +0000 Subject: [PATCH 1/2] added how to generate your public ssh key on the README.md file --- diff --git a/README.md b/README.md index 9148773..4193fd9 100644 --- a/README.md +++ b/README.md @@ -25,15 +25,36 @@ The landingpage is now running at * Try Fedora QA Dashboard yourself, clone the repo, browse the code, try to do a small change and see the results. If you want to start contributing to this project, look for issues tagged "easyfix". + +### How to generate your public SSH Key, because you will need it before you can do a pull request + +* Before generating your key, you should check to make sure you dont already have your ssh key + +* You can easily check to see if you already have the key by going to the directory and listing it + + $ cd ~/.ssh + $ ls + authorized_keys2 id_dsa known_hosts + config id_dsa.pub + +* Open your shell/terminal and type in the command + + $ ssh-keygen -o + +* Visit (https://git-scm.com/book/en/v2/Git-on-the-Server-Generating-Your-SSH-Public-Key) for more information on SSH Keys. + ### How to do pull requests * create an account on Pagure, don't forget to add your public ssh key to Pagure (click on your avatar > My settings > SSH Keys > Add SSH key) * fork this repository (upper right corner) -* clone your forked repo using SSH option +* clone your forked repo using SSH option by running the command below +``` +$ git clone +``` -* add our repo as upstream remote +* add our repo as upstream remote by running the command below ``` $ git remote add upstream https://pagure.io/fedora-qa/landingpage.git ``` From aa4fd144eab07cfb56860cac841867619f37b16e Mon Sep 17 00:00:00 2001 From: Queen Date: Apr 08 2021 03:50:36 +0000 Subject: [PATCH 2/2] Changed Source Link component from Class based to funtional and also added icon and onpress props to Source link component --- diff --git a/src/landingpage/Blockers.js b/src/landingpage/Blockers.js index 30b923a..34d7366 100644 --- a/src/landingpage/Blockers.js +++ b/src/landingpage/Blockers.js @@ -14,7 +14,7 @@ class Blockers extends Component {

Fedora {this.props.release} blockers and FEs{" "} - +

diff --git a/src/landingpage/Events.js b/src/landingpage/Events.js index 54eb80b..ee1ba9c 100644 --- a/src/landingpage/Events.js +++ b/src/landingpage/Events.js @@ -32,7 +32,7 @@ class Events extends Component {

Meetings and testdays in the next 7 days{" "} - +

    {meetings}
@@ -46,9 +46,7 @@ class Event extends Component {
  • {this.props.start}
    - - {this.props.summary} - +
    • ) diff --git a/src/landingpage/Hideable.js b/src/landingpage/Hideable.js index aac075a..f8dc7de 100644 --- a/src/landingpage/Hideable.js +++ b/src/landingpage/Hideable.js @@ -1,5 +1,6 @@ import React, { Component } from "react" import _ from "lodash" +import SourceLink from "./SourceLink" class Hideable extends Component { constructor(props) { @@ -22,13 +23,13 @@ class Hideable extends Component { : "" }> {this.props.children} - this.props.toggle_handler(e, this.props.component_name)} - role="button"> - {this.props.is_enabled ? "Disable" : "Enable"} - + linkName = {this.props.is_enabled ? "Disable" : "Enable"} + role="button" + />
    ) } diff --git a/src/landingpage/LandingPage.js b/src/landingpage/LandingPage.js index b1bee82..e480ed1 100644 --- a/src/landingpage/LandingPage.js +++ b/src/landingpage/LandingPage.js @@ -14,6 +14,7 @@ import { connect } from "react-redux" import { loadData } from "../actions/reduxActions" import Cookies from "universal-cookie" +import SourceLink from "./SourceLink" class LandingPage extends Component { constructor(props) { @@ -113,6 +114,7 @@ class LandingPage extends Component { ? "Save changes" : "Configure visibility of the info-cards"} +
    diff --git a/src/landingpage/Minutes.js b/src/landingpage/Minutes.js index 4f88f2b..f7b21d3 100644 --- a/src/landingpage/Minutes.js +++ b/src/landingpage/Minutes.js @@ -1,4 +1,5 @@ import React, { Component } from "react" +import SourceLink from "./SourceLink" class Events extends Component { render() { @@ -6,17 +7,11 @@ class Events extends Component {

    Fedora QA Meeting Minutes

    - - Latest minutes from {this.props.data.date} - +
    Visit{" "} - - meetbot - {" "} + + {" "} to see older.
    diff --git a/src/landingpage/SourceLink.js b/src/landingpage/SourceLink.js index 76cfa0b..a454a8a 100644 --- a/src/landingpage/SourceLink.js +++ b/src/landingpage/SourceLink.js @@ -1,17 +1,23 @@ -import React, {Component} from 'react' -class SourceLink extends Component { - render() { - return ( - - - - ) - } +import React from 'react' + +const SourceLink = ({ href, className, linkName, onClick, role, icon }) => { + + return ( + + {icon && } + + {linkName} + + + ) } export default SourceLink diff --git a/src/landingpage/Timeline.js b/src/landingpage/Timeline.js index 1de10c5..ee199c2 100644 --- a/src/landingpage/Timeline.js +++ b/src/landingpage/Timeline.js @@ -50,7 +50,7 @@ class Timeline extends Component {

    Current development schedule{" "} - +

    diff --git a/src/layout/Footer.js b/src/layout/Footer.js index f6cd591..d7693b0 100644 --- a/src/layout/Footer.js +++ b/src/layout/Footer.js @@ -1,11 +1,12 @@ import React, { Component } from "react" +import SourceLink from "../landingpage/SourceLink" class Footer extends Component { render() { return (
    - Source on Pagure{" "} + on Pagure{" "} version 0.1.0
    diff --git a/src/wizard/Easyfix.js b/src/wizard/Easyfix.js index ebccbfc..7e392eb 100644 --- a/src/wizard/Easyfix.js +++ b/src/wizard/Easyfix.js @@ -1,4 +1,5 @@ import React, { Component } from "react" +import SourceLink from "../landingpage/SourceLink" import { CollapsableCard } from "./components" export default class Easyfix extends Component { @@ -76,9 +77,7 @@ class EasyfixLinksList extends Component { render() { const items = this.props.data.map((action) => (
  • - - {action.name} - +
    • )) diff --git a/src/wizard/FedoraEasyKarma.js b/src/wizard/FedoraEasyKarma.js index d4e6be6..aea974b 100644 --- a/src/wizard/FedoraEasyKarma.js +++ b/src/wizard/FedoraEasyKarma.js @@ -1,4 +1,5 @@ import React, { Component } from "react" +import SourceLink from "../landingpage/SourceLink" import { CollapsableBadge } from "./components" export default class FedoraEasyKarmaItemsList extends Component { @@ -12,9 +13,9 @@ export default class FedoraEasyKarmaItemsList extends Component { needs to be tested and proved functional.{" "} The updates are kept in{" "} - - Bodhi - + + + , which acts as a gatekeeper between new package releases and the stable repositories.{" "} Users (or automated systems) can then provide feedback in form of positive/negative Karma, marking the update as working (or not) within the scope of their expectations.{" "} @@ -29,12 +30,8 @@ export default class FedoraEasyKarmaItemsList extends Component {
    • Visit{" "} - - FAS Sign-up page - {" "} + + {" "} and create it.
    • Note the username and password, you will need it later on.
      • @@ -101,12 +98,8 @@ export default class FedoraEasyKarmaItemsList extends Component { far as you can tell), or -1 to mark the package as broken.{" "}
      Not sure you can judge the package's state? Have a look at the{" "} - - Update Feedback Guidelines - + +
      Still not sure? Just press Enter to skip it. diff --git a/src/wizard/FedoraManualTesting.js b/src/wizard/FedoraManualTesting.js index 21fbc21..f852ab2 100644 --- a/src/wizard/FedoraManualTesting.js +++ b/src/wizard/FedoraManualTesting.js @@ -1,5 +1,6 @@ import React, { Component } from "react" import { Modal, ModalHeader, ModalBody, ModalFooter } from "reactstrap" +import SourceLink from "../landingpage/SourceLink" import { CollapsableCard, CollapsableBadge } from "./components" export default class FedoraManualTesting extends Component { @@ -91,12 +92,8 @@ class FedoraManualTestingItemsListSub1 extends Component { environments like EC2 or Openstack, you can also perform them locally using Testcloud.
      Have a look at the{" "} - - Cloud provider setup - {" "} + + {" "} guides for more details. ) @@ -164,9 +161,8 @@ class FedoraManualTestingItem extends Component {
      1. Identify the testcase and `environment` in our{" "} - - Tescase matrix - {" "} + +
        • @@ -186,9 +182,8 @@ class FedoraManualTestingItem extends Component {
        • Read the{" "} - - Testcase - {" "} + + {" "} briefly, just to have a general idea of what you will be doing.{" "} The testcases are generally split into four sections: @@ -215,12 +210,8 @@ class FedoraManualTestingItem extends Component {
        • Based on the enviromnent, select and download and appropriate ISO{" "} - - here - + + .{" "}
            @@ -253,9 +244,8 @@ class FedoraManualTestingItem extends Component {
          • Study the{" "} - - Testcase - {" "} + + {" "} thoroughly, to be sure you know what to do.{" "}
              @@ -288,12 +278,8 @@ class FedoraManualTestingItem extends Component { IRC channel #fedora-qa at freenode.net{" "} If you are not that familiar with IRC, you can use the{" "} - - web-interface - {" "} + + {" "} just enter a Nickname of your choice, #fedora-qa (including the hash sign) in the Channels field, and click Connect. @@ -307,9 +293,8 @@ class FedoraManualTestingItem extends Component { Great! Either use relval report-results on command line (make sure to install the relval package first), or modify the{" "} - - matrix - {" "} + + {" "} directly by clicking on the Edit link next to the Matrice's header, and put {{result|pass|YOUR_NAME_HERE|}} in the appropriate spot. @@ -351,9 +336,8 @@ class FedoraManualTestingItem extends Component { Once you get the Bug reported, make sure to also submit the result into the testing matrix. Either use relval report-results on command line (make sure to install the relval package first), or modify the{" "} - - matrix - {" "} + + {" "} directly by clicking on the Edit link next to the Matrice's header, and put {{result|fail|YOUR_NAME_HERE|BUG_NUMBER|}} in the appropriate spot. @@ -388,9 +372,12 @@ class ModalInfo extends Component { return (
              - this.toggle(e)}> - {this.props.buttonLabel} - + + this.toggle(e)} + /> Nothing sparked joy?
              None of the above looks interesting to you? We'd be happy if you looked around at{" "} - https://whatcanidoforfedora.org/! + + !
              diff --git a/yarn.lock b/yarn.lock index 85bfaa4..c4c6e7c 100644 --- a/yarn.lock +++ b/yarn.lock @@ -5190,6 +5190,11 @@ https-browserify@^1.0.0: resolved "https://registry.yarnpkg.com/https-browserify/-/https-browserify-1.0.0.tgz#ec06c10e0a34c0f2faf199f7fd7fc78fffd03c73" integrity sha1-7AbBDgo0wPL68Zn3/X/Hj//QPHM= +i18n-js@^3.8.0: + version "3.8.0" + resolved "https://registry.yarnpkg.com/i18n-js/-/i18n-js-3.8.0.tgz#b8fd6b12e1d88cb71f9806c29bca7c31c012e504" + integrity sha512-hDsGgPuvw/2P+lXSbOafAwspK8Ste8YrwuuUg17W3wEcO1JkQxBlPgsN1t2+852nTnz4YSYTjZc/1nAA2PC/nw== + iconv-lite@0.4.24, iconv-lite@^0.4.24: version "0.4.24" resolved "https://registry.yarnpkg.com/iconv-lite/-/iconv-lite-0.4.24.tgz#2022b4b25fbddc21d2f524974a474aafe733908b"