#59 Fix build issues related to EPEL 10
Merged by mymindstorm. Opened by lihaohong.
lihaohong/fedora-packages-static master  into  master

Download 59.patch

Fix #58 by adjusting version number checks (cherry-picked from #57 by @thebeanogamer) and database file name regexps.

make all works on my machine after these changes.

2 new commits added

  • Fix database regex patterns
  • Update Variable Type to Handle EPEL10 Branching

Looking at these regexps again, I think some of them may not have been written correctly. Expressions like [\w|\d] have several problems:

  1. \w and \d are not escaped properly and result in a warning. Prepending r to the string resolves this.
  2. Inside the square bracket, | is not interpreted as "or". Instead, it is interpreted literally, as can be tested on pythex: [a|b] will be able to match |. I don't think the original author intends to match | itself since this symbol shouldn't be in version numbers.
  3. \d is a subset of \w since \w matches any alphanumeric character, so the \d part is redundant.

These issues don't affect the correctness of the program, though, so I didn't try to fix them.

I tested podman-compose up on this version. Package search is working, and I'm seeing the latest kernel versions, so I think this PR is all good.

Pull-Request has been merged by mymindstorm

Metadata