#40 Fixed typo and clarified text
Closed by rlengland. Opened by rlengland.
rlengland/fedora-magazine fixes  into  master

Download 40.patch

"one more time" Did I make a mess of it again? Won't these self correct?

I got the spanish.=F0=9F=99=82

I'm still seeing another typo -- gfet -- in the green (edited) text here:
https://pagure.io/fedora-magazine/pull-request/40#request_diff

On Tue, Dec 14, 2021 at 8:52 AM Richard England pagure@pagure.io wrote:

rlengland commented on the pull-request: Fixed typo and clarified text
that you are following:
I was trying "one more time" Have I made a mess of it? I think these will self correct, no?

To reply, visit the link below or just reply to this email
https://pagure.io/fedora-magazine/pull-request/40

What is the proper way to call this back and start over?

I think you can just push another commit to your branch on your fork and
it will update/merge the fix into the PR. However, if you don't "squash"
the commits, your old/broken commit will still show up in the history of
the edits on the live site. Performing a squash commit is probably the
"proper" way to do it, but it is more complicated. If you don't mind your
bad revision being in the history, then it is OK to just push another
commit. If this were a code repository and the bad commit represented a
broken state that you really didn't want anyone to see or
accidentally build from, then the squash would be more important.

So it is up to you whether you want to push another commit on top of this
one or submit a fresh PR.

On Tue, Dec 14, 2021 at 9:12 AM Richard England pagure@pagure.io wrote:

rlengland commented on the pull-request: Fixed typo and clarified text
that you are following:
What is the proper way to call this back and start over?

To reply, visit the link below or just reply to this email
https://pagure.io/fedora-magazine/pull-request/40

1 new commit added

  • another typo

Pull-Request has been closed by rlengland

Metadata