#359 Missing QML module dependencies
Closed: Fixed by yselkowitz. Opened by yselkowitz.

In the process of creating flatpak builds, I can confirm at that least angelfish, arianna, kasts, koko, and ktrip are missing Requires: kf5-kirigami2-addons, and at least angelfish and kalk are missing Requires: qt5-qtfeedback.

Note that BuildRequires: cmake(KF5KirigamiAddons) or cmake(Qt5Feedback) does NOT ensure that the corresponding Requires is created, since these are QML modules and AFAICS we don't have methods for autodetecting requirements for those.

Since there are already multiple cases of this involving multiple libraries, this seems to be a bigger issue that needs to be verified across all QML modules (some of which are included in the Flatpak runtime and are therefore less noticeable) and their consumers. Therefore, I wanted to bring this to the attention of the SIG so this can be handled more thoroughly.


alligator is also missing kf5-kirigami2-addons

So it seems we need a way to detect these easily and add them as
run-time dependencies. Are you able to create merge requests for all of
the ones you've been able to identify so far?

On 25/5/23 12:11, Yaakov Selkowitz wrote:

yselkowitz added a new comment to an issue you are following:
alligator is also missing `kf5-kirigami2-addons`

To reply, visit the link below or just reply to this email
https://pagure.io/fedora-kde/SIG/issue/359

We have a ticket about adding a QML dependency generator (#37).

Filed:
https://src.fedoraproject.org/rpms/alligator/pull-request/1
https://src.fedoraproject.org/rpms/angelfish/pull-request/1
https://src.fedoraproject.org/rpms/arianna/pull-request/1
https://src.fedoraproject.org/rpms/kalk/pull-request/1
https://src.fedoraproject.org/rpms/kasts/pull-request/1
https://src.fedoraproject.org/rpms/koko/pull-request/1
https://src.fedoraproject.org/rpms/ktrip/pull-request/1

I think they're all merged now. Thanks!

On Tue, May 30, 2023 at 6:28=E2=80=AFAM Yaakov Selkowitz pagure@pagure.io=
wrote:

yselkowitz added a new comment to an issue you are following:
Filed: https://src.fedoraproject.org/rpms/alligator/pull-request/1 https://src.fedoraproject.org/rpms/angelfish/pull-request/1 https://src.fedoraproject.org/rpms/arianna/pull-request/1 https://src.fedoraproject.org/rpms/kalk/pull-request/1 https://src.fedoraproject.org/rpms/kasts/pull-request/1 https://src.fedoraproject.org/rpms/koko/pull-request/1 https://src.fedoraproject.org/rpms/ktrip/pull-request/1

To reply, visit the link below or just reply to this email
https://pagure.io/fedora-kde/SIG/issue/359

Metadata Update from @yselkowitz:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

Metadata