In the productmd metadata, these osbuild-built installer images
have their 'type' as "dvd". This is not correct: the "dvd" type
is meant to be a traditional RPM-based installer image, like the
old Everything DVD or the current Server DVD. The correct "type"
for an ostree installer image is "dvd-ostree" or
"dvd-ostree-osbuild".

This 'manifest_type' thing was added after the discussion in
https://pagure.io/pungi-fedora/pull-request/1190 , to let us
specify the productmd type for osbuild-built images correctly.
In this case we want to use "dvd-ostree-osbuild" because for
F39 the osbuild image is "experimental" and there still exists
an image built the older way which has the "dvd-ostree" type,
so we don't want to collide with it.

The practical consequence of this at present is the osbuild
images aren't getting openQA testing, because openQA relies
on this property to identify the image, and it's not expecting
to see "dvd". As of right now it also would not test an image
with "dvd-ostree-osbuild" type, but I can easily update it to
test those images the same way it tests "dvd-ostree" images.

Signed-off-by: Adam Williamson awilliam@redhat.com