fedora-infra / toddlers

#170 SCM processor fails to handle some odd requests
Closed by zlopez. Opened by tibbs.

Closed
Reopen Issue

An odd SCM request came through with a namespace of "null". Not the string, but a null value:

https://pagure.io/releng/fedora-scm-requests/issue/54908#comment-866436

    {
     "action": "new_branch",
     "branch": "epel9",
     "namespace": null,
     "repo": "golang-github-vultr-govultr-3",
     "create_git_branch": true
    }

leading to this backtrace:

Traceback (most recent call last):
  File "/code/toddlers/plugins/scm_request_processor.py", line 200, in process
    self.process_ticket(issue)
  File "/code/toddlers/plugins/scm_request_processor.py", line 312, in process_ticket
    self.create_new_branch(issue, issue_body)
  File "/code/toddlers/plugins/scm_request_processor.py", line 682, in create_new_branch
    namespace = issue_body_json["namespace"].strip()
AttributeError: 'NoneType' object has no attribute 'strip'

I can think of a couple of ways to fix it but you probably want a general fix and not the random hack I would produce.

Metadata Update from @zlopez:
- Issue tagged with: cpe

Metadata Update from @zlopez:
- Issue assigned to zlopez

Fixed in https://pagure.io/fedora-infra/toddlers/pull-request/339

Metadata Update from @zlopez:
- Issue status updated to: Closed (was: Open)
Metadata

cle

None
None
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.