#556 show descriptions of widgets in the widget select
Merged by abompard. Opened by ryanlerch.
ryanlerch/fedora-hubs widget-descriptions  into  develop

Download 556.patch

Leftover? :-)

The attribute should be className, not class. Also, I get a warning in the console that says "<div> cannot be a descendant of <p>".

Please change the argument name to selectedOption (like in the docs) so we don't confuse it with a standard DOM event.

rebased onto 6bd18d89214be47158f6bd6e26ebdaad91ada50f

thanks for the review! fixed these issues.

Also, had a go at adding different descriptions for when they show on different hub types. This is useful, for example in the meetings widget case where on a team hub, it just shows the team meetings, but on a stream hub, it shows all the meetings for teams you are subscribed to.

sorry for adding a new feature mid-pr :D

rebased onto b2f99b759004b0adb8a5f7eff7f69e3b3d986e2d

I like it a lot, thanks! :thumbsup:

Commit 67038c4d fixes this pull-request

Pull-Request has been merged by abompard

Pull-Request has been merged by abompard

Metadata