fedora-hubs

#540 Use whoosh for hubs search
Opened by shaily. Modified
shaily/fedora-hubs search  into  develop

Download 540.patch
no initial comment

1 new commit added

  • Disable plugins

rebased onto 9f31a3b3b798ebc12431709a65c15ace3bf125ea

rebased onto 6c9067c6d931394cc964ba126d8cc5e185f6a213

rebased onto 58fd90537a64f4026218d8dd60f55ab27b395b82

rebased onto cb6049c89341854a4232b8e30072e5047027c8bf

rebased onto eeb9e6a4726b1346bc9c3b3b53de30ca722653da

rebased onto 267e2c03d3b2dee242da712e8dce920cb8c44e61

rebased onto 266044f8bda13bdbb848aa3c96dd711050c6d422

I recommend adding a docblock here.

I recommend a docblock here.

Does hubs have an initialization function that gets called during application startup? I usually recommend against having imports cause "actions" to happen, because this can cause tricky to debug problems (circular imports, difficult to predict startup order, and difficult testing). A lot of web frameworks give you hooks that will get called when the application starts up, and these are nice because they solve the above problems.

I recommend adding tests for this change, but LGTM otherwise.

rebased onto c43463c0ea427e45ee262c3da157937f454d8c37

2 new commits added

  • Don't execute index function on import
  • Add docblocks to search code

There seems to be some problem with my setup, I'm getting an unsupported pickle protocol: 4 error on the python27 environment and missing packages on python36 while running tests using tox.

I'll try to setup the VM afresh again and add tests.

rebased onto ca5e659e03bb807321ddbded3ef48e3ad405039a

3 new commits added

  • Add tests for search
  • Explicitly fire hub created signal for team hubs
  • Change search analyzer for summary

rebased onto 1c584f70205ba78d75b8712fbaf3671371b892f5

rebased onto 011913ee523a7dfafb47bbb58817c3cb5eb822d0

1 new commit added

  • Fix team hub creation in tests

7 new commits added

  • Fix team hub creation in tests
  • Add tests for search
  • Explicitly fire hub created signal for team hubs
  • Change search analyzer for summary
  • Don't execute index function on import
  • Add docblocks to search code
  • Use whoosh for hubs search

1 new commit added

  • Add search index update test

Added tests, requesting review.

1 new commit added

  • Update populate.py to create team hubs correctly

rebased onto 5012475890b66b7363b14682cbdfdb25ea839278

rebased onto e6cd18070d11cac3117516e4d73843e8cd125b2f

Looks reasonable to me.

rebased onto d688d9260d6920578d4c6ae5343fbace41afe3fc

@abompard Is this appropriate?

Ideally you have chosen another method name, this seems a bit too generic, and could be mixed up with "getting" an index value. Maybe update_index()?

This should be a configuration value, so it can be changed by the site admin.

rebased onto 62b952a130eb2cb139098d0e4db52c45b5ccd3d8

1 new commit added

  • Changes after review

1 new commit added

  • Change config key name

Why are you getting the hub index here? It does not look like you're using that variable, or importing it from anywhere. Or did I miss it?

Oh, I'm just setting up the hub search index directory at the initialization of the application, as suggested by @bowlofeggs
I'll remove the variable assignment.

1 new commit added

  • Remove redundant variable assignment

rebased onto 8d7a216f2f0e1385c64a44ae8e508fb5325d481e

1 new commit added

  • Fix team hub creation in populate.py
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.