#503 tidy up css and font files
Merged by abompard. Opened by ryanlerch.
ryanlerch/fedora-hubs tidy-css-and-fonts  into  develop

Download 503.patch

this commit does some general tidyup of how we handle some
of the CSS and font files.

First, the two fonts we use, open sans and fontawesome are now
set up to be pulled down from the central copies we have hosted
on apps.fp.org/global. Note that due to CORS restrictions, this
means these fonts will work on prod, but not when testing locally.
If you install the fonts locally on the system you are looking at
the test site at, it will use the fonts. Details on this have been
added to the dev documentation.

Second, we remove the cantarell and comfortaa fonts in the repo,
as these were not being used. We also delete the style-patternlab.css
file that was not being used either.

rebased onto 7bfcb3750a3259f40b588b3ce0529e51d748e023

rebased onto 463162924152269ec62bf0f6c82f1d852eaa83d0

rebased onto 50cda25f52cc01d2f4b751491f3676ba29f8a7c0

LGTM

I think this must stay. That's where webpack extracts and compiles the CSS included in the React files.

The js/css/style.css is generated by webpack when run in production mode (npm run build), so it must stay even if it causes a 404 error during development.

rebased onto db4a52c34df61087c32eb4b51c60ed56b747e54a

@bowlofeggs and @abompard -- thanks for the reviews!

@abompard -- added back the line in master.html that imports js/css/style.css

cheers,
ryanlerch

Great! Can you please also add to the doc that the browser must be restarted after the fonts are installed locally? If figured it out fast enough but it doesn't hurt to mention it ;-)

rebased onto 02b7f352818a08f0dff8147d750acca874cf2de8

@abompard -- done!

rebased onto e7c4d9cc923811e46b39dbf604997ce30d53f4d2

Pull-Request has been merged by abompard

Metadata