#440 Integrate the stats widget in the hub header
Merged by abompard. Opened by abompard.
abompard/fedora-hubs feature/hub-stats  into  develop

Download 440.patch

I recommend against leaving TODOs in the code - I suggest filing a ticket instead so it doesn't get forgotten.

For a second I thought this was Python and I was like "whoah I had no idea you could import this way!"

I recommend a docblock here that includes the type of the parameter and return value.

I recommend a docblock here as well.

Similar here - I recommend filing a ticket instead of a TODO.

If this code isn't needed, I recommend deleting it rather than commenting it.

LGTM!

P.S. If you have some time, I've got a lot of PRs that need review over at Bodhi: https://github.com/fedora-infra/bodhi/pulls

Thanks @bowlofeggs . I'll file the tickets instead of the todos and add the docblocks.

I'll go check out your PRs too :-)

rebased onto c3f1cbd5730264b9d95358364daef71ae10f0931

Pull-Request has been merged by abompard

Metadata