fedora-hubs

#338 Configuration panel for Hubs
Merged by abompard. Opened by abompard.
abompard/fedora-hubs hub-config  into  develop

Download 338.patch

These commits add the following features:

  • a table to hold hub-specific configuration values
  • a configuration panel to edit them
  • a configuration setting for the channel / network a team may be using

See issue #331 for the mockup. Again, commits are best read in order.

Neat, I didn't know about this.

This is a pretty big pull request!

I don't know JS too well, but it all looks reasonable to me. I didn't see any tests, so the only suggestion I have is to make sure the new Python code has test coverage.

LGTM.

Oh, right, my view tests weren't committed and pushed, I'll do that ASAP.

Sorry for the big PR but it touches the core hub framework so I can't make it much smaller... I tried to keep "atomic" commits that can be understood by themselves.

About the new Alembic batch operation, it's Barry (core dev of Mailman 3) who contributed it so I've heard about it from there :)

Thanks for reviewing!

2 new commits added

  • Create a validator class for POST data
  • Test the config view

16 new commits added

  • Create a validator class for POST data
  • Test the config view
  • Don't use the minified version in DEBUG mode
  • Improve the display of the edit links
  • Reload the page when the config changed
  • Move the right_width property along with the config
  • Pass the props when instantiating the panel
  • Be more careful about what's stored in the DB
  • Auto-save the settings
  • Implement the General Settings panel
  • Add the chat configuration parameters
  • Implement the config panel backend
  • Implement the config panel UI
  • Prepare a React component for the hub config panel
  • Use eager loading for the hub config
  • Create a table for hub configuration

If just added tests and validation for the configuration view (last 2 commits). It's only Python this time, no JS ;-)
Edited by abompard

LGTM

Pull-Request has been merged by abompard
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.