#300 Fix Python3 support
Merged by jcline. Opened by abompard.
abompard/fedora-hubs fix-python3  into  develop

Download 300.patch

Small fixes to make the code run on Python 3.

Since this looks like a new requirement, would it be better to pick up requests as a dependency instead? Admittedly with the code below it only saves a few lines.

It would be good to add classifiers to the setup.py so it's clear to new developers what version of Python are supported. I do much prefer requests to httlib2, but it's not a blocker for me. Other than that, it looks good to me!

The reason I chose httplib2 is because it's already a requirement for flask_oidc, but requests is also a requirement for fedmsg, so it doesn't really matter to me. I'll update the code for requests and the classifiers in setup.py.

1 new commit added

  • Use requests instead of httplib2

You might want to slap a timeout=<timeout in seconds> to this since by default there is no timeout and this could hang for an indefinite amount of time.

One suggestion, but it looks good :thumbsup:.

1 new commit added

  • Add a timeout to the requests-based validators

Done, thanks for reviewing.

:thumbsup: merge whenever you're ready!

I'm apparently not allowed to merge, can you do it?
Thanks.

rebased

Pull-Request has been merged by jcline

Metadata