#239 Add tests for React front end
Merged by atelic. Opened by atelic.
atelic/fedora-hubs js-tests  into  develop

Download 239.patch
  • Use jest test suite (recommended by React team)
  • Explain how to run JS tests in README

Need to run npm install before running the tests

Not a hardcore js dev but its looks good :thumbsup:

5 tests passed (5 total in 4 test suites, run time 8.43s)

1 new commit added

  • Add script for running tests from root hubs dir

new script works for me as well

rebased

Is the location of the tests under the static folder something that is standard or so?
Seems odd for me to ship them there as I'm afraid we'll forget to remove them in installing later :/

Is the location of the tests under the static folder something that is standard or so?
Seems odd for me to ship them there as I'm afraid we'll forget to remove them in installing later :/

I don't know if it is standard but the only other experience I have with javascript testing does it the same way: https://github.com/CenterForOpenScience/osf.io/tree/develop/website/static/js

Not to say that way is correct though.

rebased

rebased

@sayanchowdhury what are your thoughts on this?

Sayan confirmed the tests here but wants to run them to be sure.

:thumbsup: for me

rebased

Pull-Request has been merged by atelic

Metadata