This makes the bookmarks bar vertical and cleans up some style issues that the vertical bookmarks bar exposed.
http://i.imgur.com/AsZ8MMJ.png
Could we get the buttons to have have the same width or no?
Semantic markup :) :thumbsup:
Indentation mistake here?
perhaps margin and outset ?
skrzepto - i'm going to work on the buttons but in a different PR... figured i'd try to separate the work into logical chunks, so this one is just for the vertical bookmarks bar related stuff
atelic - yep whoops! missed that indentation, will fix now
@duffy
oops sorry about that :P just noticed the top left. No worries :)
This looks really nice. Just a couple of quesitons about the indentation. It looks like tabs are mixed with spaces some here. example. another.. I think our standard it to have two spaces for html/css/js files.
1 new commit added
you know what i think happened with the tabs/spcaes... my editor (geany) has them set up right but i had a merge conflict when i was rebasing and i did those fixes in vim... lol. ill go thru and clean up the tabs.
:thumbsup: from me. @pingou might have a comment about the commit history though. I think the policy is to not have merge commits but rather a linear history.
rebased
Pull-Request has been merged by duffy
This makes the bookmarks bar vertical and cleans up some style issues that the vertical bookmarks bar exposed.