#229 Add the trac widget for ticket coming from fedorahosted
Merged by pingou. Opened by pingou.
pingou/fedora-hubs trac_widget  into  develop

Download 229.patch

Fixes https://pagure.io/fedora-hubs/issue/174

Fixes as well a couple of small issue to the Pagure PR widget and the meetings one

When I enter gibberish into the project name it returns

Got an error retrieving this widget. Sorry :(

I'd like it to note that

project is either non-existent or connection timed out

Because now I'm unable to edit the project name

Adding the widget works correctly and looks good. However, updating the number of tickets to display causes the widget to break. traceback

How does this look http://img.susepaste.org/428119a5 ?

That looks fine :)

1 new commit added

  • Show an error message upon error :)

After manually updating the db for this widget project to "fedocal". It loads fine. When I try to update the number of issues it reverts the project to true again.

1 new commit added

  • Fix the validator used in the fedorahosted widget

Confused by this line? But im assuming this wan't needed to fix this pr but was something needed to be done

Indeed, we want the validators to return the value, not a True/False

This works for me :)

even with negative number in posts 1 issue is shown which is ideal :)

:thumbsup: lgtm

Works for me now :thumbsup:

Thanks for the reviews :)

Pull-Request has been merged by pingou

Metadata