Just quick comment. I think I read up somewhere its not wise to insert the sources for libraries like this and to use a package manager like npm. Does react have an easy way to be installed like that and could we insert that to the setup.py script?

Hmm, I forgot that they are now installed with npm so the source folders shouldn't be needed. I was including them before I figured out how to get webpack to compile.

I've removed them locally with no problem. Hopefully that will make this easier to review too.

awesome :) that would be much less daunting to review :P

Does this do a system wide install or is there a way to do it only locally (in the home folder or the cwd)?

pickle?

As I understand it, when run without the -g (--global) flag, npm will only install these modules in the root of the project.

http://stackoverflow.com/a/14032346

Yes, -g does a global installation.

Using pickle because some stronger serialization on the matches list.

For example:

>>> d = { 'aset': set(['thing1', 'thing2']) }
>>> json.dumps(d)

TypeError: set(['thing1', 'thing2']) is not JSON serializable.

The more I think about it, the more that I think this isn't the right way to do it. Sure it got rid of the error messages but we are probably losing some data in there.

Cool :)

I don't think we loose data per say, but I do agree that going via pickle isn't really nice.

If possible I'd rather have us stick with json

What about something like::

class PythonObjectEncoder(json.JSONEncoder):
''' A JSON encoder that handles python data structures in encoding'''
def default(self, obj):
    if isinstance(obj, (list, dict, str, unicode, int, float, bool,
                        type(None))):
        return json.JSONEncoder.default(self, obj)
    if isinstance(obj, set) or isinstance(obj, tuple):
        return list(obj)
    if isinstance(obj, object):
        return obj.__dict__
    else:
        raise TypeError

typo?

Yes, fixed now

Looks fine to me but I'm clearly not the most knowledgeable person on react :)

:thumbsup:

Looks good to me. :thumbsup:

Good to merge?

@atelic @sayanchowdhury gave his :thumbsup:, so let's do it! :)

Woo! :ship: :tada: