#198 Adding unittests
Merged by skrzepto. Opened by skrzepto.
unittest  into  develop

Download 198.patch

Atelic and I have added 48 new tests and thought it would be a good time to merge unittest into master.

currently at 64% coverage.

Could we move this import as well as the from hubs.widgets.feed above down into the endpoint so that we know they should go away when we remove this endpoint as well?

1 new commit added

  • Move hubs.feed and PATHS down to temp endpoint

What about using self.assertIn()?

Is this the equivalent of self.assertNotNone()?

Commented out?

Should check more precisely what is returned? (Can we?)

yea i'll delete that, this was because i was getting flask errors and decided to test the route instead

1 new commit added

  • cleaning up current tests in the widgets folder

Anything else needed on this?

If we turn on running the tests on jenkins, we should consider using faitout: http://faitout.fedorainfracloud.org/

This is how I handle it in pagure to keep sqlite/memory DB for local tests and use faitout on jenkins: https://pagure.io/pagure/blob/master/f/tests/init.py#_40-53

(This can wait for another PR though)

We likely do not want to query FAS to run our tests :)

Couple of comments but nothing blocking this from being merged imho, so :thumbsup: for me

Pull-Request has been merged by skrzepto

Metadata