fedora-hubs

#188 Add checks for None in meetings widget
Merged by atelic. Opened by atelic.
atelic/fedora-hubs fix/meetings-break-with-none  into  develop

Download 188.patch

Purpose

Right now there is some data that gets pulled down that has None for meeting_location and/or meeting_information. This causes breakage and the meetings widget will not load.

Changes

  • Checks in meetings.py that avoid iterating or calling a function on None
  • Check in meetings.html that is a result of the above

LGTM :thumbsup:

FTR you don't need to specify None in the second part as if there is no second argument, it will default to None

>>> print {}.get('foo')
None
>>> print {}.get('foo', None)
None

:thumbsup: for me as well

Thanks. Would you like me to remove the two instances of it?

As you like, it doesn't do any arm but we might as well get them out of the way while we think of it

rebased

Cool, go ahead and merge :)

Preferred way? Just use the merge button here?

The merge button here should work just fine :)

Pull-Request has been merged by atelic
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.