fedora-eln / eln-scripts

#1 Adding initial revision of untag-trimmed-builds.py
Merged by sgallagh. Opened by merlinm.
fedora-eln/ merlinm/eln-scripts untag-trimmed-builds  into  main

Download 1.patch

WARNING: I have not run this without the --dry-run option!

1 new commit added

  • Improvements:

I still haven't run it without the --dry-run option.

Nitpick: Please print this to stderr.

Also should be stderr, but I appreciate the humor in the message!

It's kind of a nitpick, but please use Python's logging facility. For consistency, you can follow the model of https://pagure.io/fedora-eln/eln-scripts/blob/main/f/find_eln_failures.py#_86

1 new commit added

  • Split get_distro_packages() into a separate library/script

3 new commits added

  • Address review feedback and improvement
  • Improvements:
  • Adding initial revision of untag-trimmed-builds.py

@sgallagh Thank you for the feedback. With my latest push, I believe I've addressed your comments in addition to splitting get_distro_packages() into a separate file that can be included as a library or run stand-alone.

Looks good to me.

Pull-Request has been merged by sgallagh
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.