fedora-docs / fedora-docs-ui

#33 Fix#9 - "Edit this page" and language selection hidden when window width is below 1024px
Merged by darknao. Opened by aghasaad04.
fedora-docs/ aghasaad04/fedora-docs-ui fix#9-crumbs&toolbar  into  main

Download 33.patch

Signed-off-by: Agha Saad Fraz agha.saad04@gmail.com

Problem:

When the window width of the browser displaying any of our docs is below 1024 px, the page attempts to save space by hiding the left side table of contents under a menu, and it also removes the top bar that displays your location in the site structure (e.g. "Home / Quick Docs / Fedora Quick Docs") as well as the Edit this Page link.

Solution:

I have removed some styling so that whenever window size becomes smaller than 1024px, those items do not get hidden.

This solves the issue :thumbsup:

Agreed, and it would be nice to get it merged.

I have two suggestions/questions, @aghasaad04 :

  1. Is there anything preventing us from doing this for the .page-languages class, as well?

  2. The .toolbar class currently has a fixed height: 30px, which means if the breadcrumbs wrap to multiple lines they spill out of the toolbar. Simply removing the height property entirely and letting the toolbar auto-size seems like it works fine, in my limited testing.

    (The 5px padding top and bottom might also be a little excessive. Normally the fixed height overrides it, so you don't see the padding. But when that's removed, the toolbar suddenly feels like it's wasting vertical space.)
Edited by ferdnyc

rebased onto e5713fed8704da178373cf8889dd027bd269c78d

Pull-Request has been merged by darknao
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.