We need to describe that pdf files should not be version controlled with git but instead created to be uploaded some other place, any ide where?
@ojn Hi, I found an issue - the new file modules/contributing/pages/producing-pdf-files.adoc isn't included in nav.adoc so it doesn't show up in the table of contents and it's not discoverable. Please add it there.
modules/contributing/pages/producing-pdf-files.adoc
nav.adoc
Also a minor problem, the PR shouldn't have included the updated scripts; I'm glad you commited them, but it should have been a separate PR. I'd say it's fine to keep it now that they're already commited, but next time please keep different updates separate.
Regarding storing PDFs - well, that's a tough one. I know binaries in repos are bad but I don't know where else to store them. Antora docs even say to store them in modules/<module>/assets, IIRC. It makes cloning take forever but the only alternative I can think of is to dump them in a directory on someone's fedorahosted space and that's a bad idea too.
modules/<module>/assets
rebased onto f921f84ad1c04b336c463ee016d5e7411bde2f5d
it should have been a separate PR.
Yeah I know, that's my inability to use git that shows through :beginner: I'm still trying to learn how to use branches correctly.
. It makes cloning take forever but the only alternative I can think of is to dump them in a directory on someone's fedorahosted space and that's a bad idea too.
Yeah that could be useful for drafts and previews, but for SEO perspective it needs to go on the main site. I think we would need to ask infrastucture team. I think @asamalik was talking that CI was on the plans for the future. I'm not a sysadmin but that would be a perfect time to think about it and opportunity to implement- how such assets can be served. Putting a reverse proxy in style with Traefik might do the trick. There seems to be a lot of knowledgeable people who like containers so we should figure out something.
1 new commit added
included pdf chapter in nav
If the assets are generated for each version, I think they should be built and placed at publish. If they are part of hte document (i.e. an example) especially something that won't change frequently, I think, much like an image, they should be committed.
Pull-Request has been closed by ojn
Metadata Update from @jflory7: - Pull-request tagged with: type - new docs
We need to describe that pdf files should not be version controlled with git but instead created to be uploaded some other place, any ide where?