#73 Issue #20 - first step to move _images/404.html to root
Closed by bex. Opened by abitrolly.
fedora-docs/ abitrolly/docs-fp-o 404  into  master

Download 73.patch

This is a copy of _image/404.html. The source file should be removed
after server configuration is updated in #20.

I believe we may need to rename this file in the root directory. Can you look at http://asciibinder.org/latest/guides/maintainer_guide.html#sites-and-homepages and run a test build?

Test build gives there warnings. Is it okay?

$ asciibinder package -l debug
Building all distributions.
CHANGING TO BRANCH 'master-en-US'
WARN: Branch 'master-en-US' includes the following .adoc files that are not referenced in the _topic_map.yml file:
- Common_Content/Feedback
- Common_Content/Legal_Notice
Building Fedora for branch 'master-en-US'
CHANGING TO BRANCH 'f28-en-US'
WARN: Branch 'f28-en-US' includes the following .adoc files that are not referenced in the _topic_map.yml file:
- Common_Content/Feedback
- Common_Content/Legal_Notice
...

I also can not test build from my branch - build script resets branch to master, and there is no 404.html file at that place. Now merging 404 branch to master for testing.

And now the build fails in asciibinder package:

CHANGING TO BRANCH 'Fedora-Council_council-docs'
Error: The topic map file at '_topic_map.yml' contains the following errors:
- Topic entity at 'Fedora Subprojects -> Engineering -> Fedora Modularity -> What is Modularity' exceeds the maximum nested depth.
- Topic entity at 'Fedora Subprojects -> Engineering -> Fedora Modularity -> How does it work' exceeds the maximum nested depth.
- Topic entity at 'Fedora Subprojects -> Engineering -> Fedora Modularity -> How does it work -> Main Concepts' exceeds the maximum nested depth.

No, I can't do anything right now, because of this failing build, and I don't know what needs to be fixed about those nesting levels.

I also can not test build from my branch - build script resets branch to master, and there is no 404.html file at that place. Now merging 404 branch to master for testing.

Sorry for the delayed response. I was traveling last week.

To fix this, modify the line master: in _distro_map.yml to refer to your branch.

No, I can't do anything right now, because of this failing build, and I don't know what needs to be fixed about those nesting levels.

Use the upstream code and run

asciibinder package -t 0

To fix this, modify the line master: in _distro_map.yml to refer to your branch.

There is no master: line in that file - https://pagure.io/fedora-docs/docs-fp-o/blob/master/f/_distro_map.yml

Use the upstream code and run

asciibinder package -t 0

How to use? Current version 0.1.14 complains abou missing -t 0 option and there is no Bodhi build for a new version - https://bugzilla.redhat.com/show_bug.cgi?id=1542967

To fix this, modify the line master: in _distro_map.yml to refer to your branch.

There is no master: line in that file - https://pagure.io/fedora-docs/docs-fp-o/blob/master/f/_distro_map.yml

doh! you're right. I was thinking of tree repos. for this run the builder with the optional branch argument.

./builder my-branch
asciibinder package -t 0

Use the upstream code and run
asciibinder package -t 0

How to use? Current version 0.1.14 complains abou missing -t 0 option and there is no Bodhi build for a new version - https://bugzilla.redhat.com/show_bug.cgi?id=1542967

The latest code is upstream here: https://github.com/redhataccess/ascii_binder

Is there a way to release a new package version, at least for updates-testing? I'd like to avoid installing things on my system that I can not uninstall and that will conflict with proper packages.

Is there a way to release a new package version, at least for updates-testing? I'd like to avoid installing things on my system that I can not uninstall and that will conflict with proper packages.

This will require the upstream to cut a new release. In theory I can do that, I will look into it next week. It is lower priority for me with the antora work, however you're reasons for wanting it are the same as mine.

In the interim, I suggest you use a container.

Wrapping 0.1.15.1 is not enough? https://bugzilla.redhat.com/show_bug.cgi?id=1542967

Can not submit PR for ascii_binder because of https://pagure.io/fedora-infrastructure/issue/6361

Now I won't have more time. This is as far as I could help.

@abitrolly thank you for your help. I am closing this as we are no longer using AsciiBinder.

Pull-Request has been closed by bex

Metadata