According to this Issue#131 we need to improve the on boarding process too.

Hey @nasirhm, I missed this PR! It was buried in notifications.

Thanks for taking initiative on fixing up the links. I have a few comments I will add before this is ready to merge. :) Thanks for working on this.

Could you please also fix link:Diversity#Team_Members[Diversity and Inclusion Team member] on this line?

https://docs.fedoraproject.org/en-US/council/diversity-advisor/[Diversity Adviser] should be an xref so it links to the Fedora Council doc page. If the URL schema ever changes, using an xref will make sure the link is always up-to-date. Note that cross-project xref's will not work locally, but they will work when pushed live onto the Fedora Docs site. If you need xref help, come find the Docs team in #fedora-docs :)

This should also be a xref to the Council docs page.

Same xref as above here.

Today I learned this is a wiki page: https://fedoraproject.org/wiki/How_to_organize_a_Fedora_event

I'm not sure how useful this link is right now… we can leave it in for now but maybe we want to remove/replace it. Please link it to the wiki page for now, thanks!

Oops, the xref path is wrong. It should be:

xref:team.adoc[Diversity and Inclusion Team]

This one should work locally since it is a page in the same docs site.

Another cross-site xref here too :)

Another cross-site xref here too :)

Another cross-site xref here too :)

Hmm… our mailing list is a good idea to make a link in our attributes.adoc file, so we can define it once and re-use the same link across the site. Like we do with {FWIKI}:

https://pagure.io/fedora-diversity/blob/0cf16140547626be653428323ade8e456877a127/f/modules/ROOT/pages/_partials/attributes.adoc

This is a little more advanced and out of scope of the PR though. If you have extra time and want to do this, that is awesome! But if not, it's okay too. We can get it in another PR.

One more general comment: please place each sentence on its own line. This is an AsciiDoc convention, but it also makes git diffs waaay easier to read. :) This is the usual standard we follow in other Fedora Docs sites, so best to be consistent here too:

https://asciidoctor.org/docs/asciidoc-recommended-practices/#one-sentence-per-line

One more general comment: please place each sentence on its own line. This is an AsciiDoc convention, but it also makes git diffs waaay easier to read. :) This is the usual standard we follow in other Fedora Docs sites, so best to be consistent here too:
https://asciidoctor.org/docs/asciidoc-recommended-practices/#one-sentence-per-line

Would try my best to use it as much as i can.

I've added the Mailing list attribute as {MAILINGLIST} that points towards the mailing list's archive.

Made the xrefs, best reference i found was engineering team docs for cross-site xrefs.

Thanks for reviewing. Do let me know if there's anything you would like to see updated. :)

Just an idea… we could probably make a {MAJOROSVER} like the quick-docs project does:

https://pagure.io/fedora-docs/quick-docs/blob/master/f/modules/ROOT/pages/_partials/attributes.adoc

We can open that in a new PR. But it would make this easier to maintain and always point to the Marketing Team's latest work.

@jflory7 Here ^ are the Changes i made:

• Addition of {MAJOROSVER} to make it easier to maintain and always point to the marketing team's latest work and used it where i mentioned the release version manually i.e: 32

• Fixed one sentence per line, I've gone through the docs and feel that it's been fixed.

I love it :smile:

Awesome, thanks @nasirhm! :raised_hands: Merging.

Thanks for Merging and helping along the way @jflory7 :)