fedora-commops / fedora-happiness-packets

#97 sidebar items center aligned and form tag moved
Merged by jflory7. Opened by phoenixabhishek.
Unknown source master

Download 97.patch

Solving issue #74 : center-aligned the contents of sidebar
The changes can be seen here

Also,
The form tag used for login/logout in the sidebar was placed inside the 'ul' element but was not a child 'li' element.
Hence removed outside for better HTML semantics.
Those changes can be viewed here

1 new commit added

  • form tag commit added

Metadata Update from @jflory7:
- Pull-request tagged with: difficulty - easy, good first issue, type - frontend

Hi @phoenixabhishek, this change is simple to me. It looks like we have to break from the upstream project since we have different design assets. I think that's okay in this case.

Merging! :clapper:

Pull-Request has been merged by jflory7
phoenixabhishek commented

Hi @jflory7 thaks for the merge.
Also, should I make a PR to the upstream (mxsasha/happinesspackets) too for this?

@phoenixabhishek This was a minor change we needed to make since our Fedora-specific logo scaled differently on mobile devices. Since it's only cosmetic, I don't think this change needs to be sent upstream.
phoenixabhishek commented

Ok, thanks :smile:
Can you assign me another issue I can work on please.
Metadata
None

difficulty - easy good first issue type - frontend

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.