#63 Fixed failing tests.
Closed by jflory7. Opened by echoduck.
fedora-commops/ echoduck/fedora-happiness-packets test-fixes  into  master

Download 63.patch

Fixed the failing tests:

For test_confirm_anonymous and test_confirm_named, Celery blocked the tests from being able to send email, so by using django-celery-email as a backend, instead of having emails sent via a standalone task, the test runner can now override Celery when running tests.

OIDC authorization prevented the SendView tests from being authenticated, so for the tests, the default ModelBackend is in use.

test_post_ratelimited_recipient had the sender email address as the recipient email address, which is why the rate limit validation approved it in the form.

test_post_ratelimited_sender failed because no validation was present for the sender email, as it was not part of the form field. by overriding get_form_kwargs to supply the request user, the form is now able to validate the sender's email.

rebased onto 5786516ef1330ac5dd41cd1943d4f979809ada32

I'm going to open up a new GCI task for this since I need some more time to review it.

rebased onto d999b5fa73507830dd3540fe250453ed36840495

Metadata Update from @jflory7:
- Pull-request tagged with: improvement, needs testing, type - quality assurance

Metadata Update from @jflory7:
- Pull-request untagged with: needs testing
- Request assigned

@echoduck Thanks, I tested these changes locally and I think this is ready to merge. Could you rebase this pull request one more time to latest changes on master branch please?

Metadata Update from @jflory7:
- Pull-request tagged with: PASSED

Actually I went ahead and rebased this PR onto master branch since it was a clean patch. This pull request was applied in commits 73fd71488dadc28e0c8995d225b8ad845f26ad18 and ce88a4f20c6ebcda923fb622caf5500ee0a139bb. Pagure doesn't close the pull request automatically when I apply the patches this way, but this pull request is effectively merged. :clapper:

Pull-Request has been closed by jflory7