This commit addresses issue #42
rebased onto ff8c6ea76281af2cf7bcb5543b2b50556ec96014
Metadata Update from @jflory7: - Pull-request tagged with: PASSED, improvement, needs review, type - frontend, type - summer coding
Thanks @shraddhaag for grabbing this one. :thumbsup:
Before merging this, I also want to update the contact info email address currently used in the application. We need to change two email addresses to instead point to pagure.io/coc. I used a recursive grep search to look up any references for the two old email addresses:
grep
$ grep -rnw . -e 'fedora.happinesspackets@gmail.com' ./happinesspackets/settings/base.py:34:DEFAULT_FROM_EMAIL = "Happiness Packets <fedora.happinesspackets@gmail.com>" ./templates/base.html:111: Need help? <a href="mailto:fedora.happinesspackets@gmail.com">fedora.happinesspackets@gmail.com</a> ./templates/base_email.html:22: Need help? <a href="mailto:fedora.happinesspackets@gmail.com" style="color: #3c6eb4;">fedora.happinesspackets@gmail.com</a>
$ grep -rnw . -e 'info@happinesspackets.io' ./templates/messaging/faq.html:82: Please report this to <a href="mailto:info@happinesspackets.io">info@happinesspackets.io</a>, preferably by ./templates/_email_footer.txt:4:and Mikey Ariel. Need help? Email us at info@happinesspackets.io
Could you please also update the above places to direct people to the right place if they need help?
Otherwise this looks good to me.
For consistency, it would be cleaner to follow the same line break convention used in other paragraphs in this document. It also makes it easier to review diffs in PRs, since Pagure doesn't wrap lines automatically.
Metadata Update from @jflory7: - Request assigned
@bex @mattdm @bcotton @jonatoni @till @ausil Could a Fedora Council member please sign-off on the language used for reporting Code of Conduct-related incidents in the FHP web app? This will close #42 opened by @bex.
Metadata Update from @jflory7: - Pull-request tagged with: needs changes
Please change line 22 to, "Please see the Fedora Code of Conduct to find the steps to report it to the Project. " - thank you.
I've submitted an update request that should allow this to be merged.
Thank you @bex!
rebased onto 6780fdc6bfefa4ef2108dd37d61ab2e31dbd91e6
Hi @jflory7! I've updated all the mentioned places except in settings/base.py. From what I understand, DEFAULT_FROM_EMAIL is the one used to send all happiness packets. I'm unsure if we should change this one. Reading Django settings, I think we should include SERVER_EMAIL.
settings/base.py
DEFAULT_FROM_EMAIL
SERVER_EMAIL
Please let me know what are the appropriate steps here. :)
Please change line 22 to, "Please see the https://docs.fedoraproject.org/en-US/project/code-of-conduct/">Fedora Code of Conduct to find the steps to report it to the Project. " - thank you.
Thank you @bex! I've updated the same :)
Nice catch @shraddhaag. I opened #244 to track the issue about outgoing email since that will actually block us from deploying the app for #111. But that shouldn't block this PR.
The updated changes look good to me! Thanks for getting this one Shraddha. Merging! :ocean:
Metadata Update from @jflory7: - Pull-request untagged with: needs changes
Pull-Request has been merged by jflory7
This commit addresses issue #42