This PR addresses issue #208.
Minor typo (exsist). I suggest revising to this: Sorry! This FAS username does not exist.
exsist
Sorry! This FAS username does not exist.
Are the changes above this line intentional? This looks like an editor applied an auto-formatting rule.
Hi @alishapapun, nice work! :raised_hands: I tested the button and it worked as expected. I had a few comments:
The changes you made look good, but it seems like multiple unrelated files were changed too. It is better practice to keep your changes limited to only what you describe in your PR (this also makes it easier to review). In the future, please keep changes like these separate.
Once the typo is fixed, I can merge this PR. :smiley:
Metadata Update from @jflory7: - Pull-request tagged with: PASSED, improvement, type - frontend, type - summer coding - Request assigned
Hi @alishapapun, nice work! ๐ I tested the button and it worked as expected. I had a few comments: The changes you made look good, but it seems like multiple unrelated files were changed too. It is better practice to keep your changes limited to only what you describe in your PR (this also makes it easier to review). In the future, please keep changes like these separate. Once the typo is fixed, I can merge this PR. ๐
I will make the required changes, and sorry, I suppose VSCode has done some auto indent stuff. I will make the changes soon.
1 new commit added
Fix typo and remove auto-formatting rule
@jflory7 made the required changes and removed auto-format.
@alishapapun This looks great, thanks for cleaning up the auto-formatting too. :smile:
Please squash your commits together and then we will merge! :clapper:
rebased onto 843dda0bd0356210c56f8f4de19265730648dfd8
@jflory7 squashed the commits :) .
Super. Thanks again for this PR @alishapapun. Merging! :clapper:
Pull-Request has been merged by jflory7
This PR addresses issue #208.