#195 Made the footer consistent across all pages and stick to the bottom regardless of the length of the page's content
Closed by anhpham. Opened by anhpham.
fedora-commops/ anhpham/fedora-happiness-packets issue-134-resolve-bug-in-footer  into  master

Download 195.patch

My second pull Request is fixing the bugs in footer implementation.
This commit includes:
1. Added the social buttons to the footer in Sender Confirmation page to make the footer look consistent across all pages.
2. Made the footer fixed to the bottom of the page no matter how long the page's content is.

As per issue 134: https://pagure.io/fedora-commops/fedora-happiness-packets/issue/134

@jflory7 hi I've solved the front end issue of the footer as you can see from this Pull Request. I'm sorry it took so long for me to finalize this pull request, but here you are! Please let me know if I need to fix anything else ๐Ÿ‘๐Ÿ‘

@jflory7 hi I've solved the front end issue of the footer as you can see from this Pull Request. I'm sorry it took so long for me to finalize this pull request, but here you are! Please let me know if I need to fix anything else ๐Ÿ‘๐Ÿ‘

@anhpham The footer work perfect in the large screen but it breaks incase of mobile view.

phoenixabhishek commented

Hi @anhpham
I see that among the files changed to achieve this, you have made a change in a bootstrap file.

This is not an efficient practice, and is avoided to prevent errors where these classes are used to achieve some styling elsewhere.

It would be great if you can keep the bootstrap files as-it-is and have solution only in our custom.css file for styling :smile: :smile: :smile: :smile: :smile:

@jflory7 hi I've solved the front end issue of the footer as you can see from this Pull Request. I'm sorry it took so long for me to finalize this pull request, but here you are! Please let me know if I need to fix anything else ๐Ÿ‘๐Ÿ‘

@anhpham The footer work perfect in the large screen but it breaks incase of mobile view.

Thank you @alishapapun ! Will fix this shortly!

Hi @anhpham
I see that among the files changed to achieve this, you have made a change in a bootstrap file.
This is not an efficient practice, and is avoided to prevent errors where these classes are used to achieve some styling elsewhere.
It would be great if you can keep the bootstrap files as-it-is and have solution only in our custom.css file for styling ๐Ÿ˜„ ๐Ÿ˜„ ๐Ÿ˜„ ๐Ÿ˜„ ๐Ÿ˜„

For sure, thanks @phoenixabhishek !

Hi @alishapapun could you help guide me on how to test my code changes via mobile view? Are there any guides to set up testing for mobile in the documentation, because I have not seen any :( ?
Or if I understand it right, is it that we can change the size of the web page via desktop browser to check if it's responsive?

Metadata Update from @jflory7:
- Pull-request tagged with: PASSED, improvement, needs testing, type - frontend, type - summer coding

Hi @alishapapun could you help guide me on how to test my code changes via mobile view? Are there any guides to set up testing for mobile in the documentation, because I have not seen any :( ?

The way I have tested changes on mobile is using Responsive Design Mode from Firefox Developer Tools. If you are using a recent version of Firefox, you should be able to do the same.

I'm pretty sure Chrome has a way to do this too but I'm not sure how.

@anhpham In case of Google Chrome open the Dev tools and select "Toogle Device Toolbar" (Button present to the right of Elements). You will be able to produce view for different devices. For more help read this.

1 new commit added

  • Updated solving issue 134: deleted Bootstrap change and made some css changes to fit mobile view

@jflory7 Hi I have updated my Pull Request!
This new commit includes:
1. Deleted previous Bootstrap change (as it is a bad practice) and keep it as it is.
2. Edited the file custom.css in order to make the footer not only consistent across all pages and fixed to bottom but also fit mobile view.

rebased onto af0d2a8b88f69bd476c45dbe30d4cfc483582620

Hi @anhpham, thanks for your changes! :thumbsup:

I tested this with different mobile device settings successfully. However, for a larger screen I had this issue where the footer went off-screen:

Screenshot of page scrolled to farthest back corner to demonstrate bug

It looks like the footer pushed the rest of the page out further. Could you please debug this issue? I tested with screen dimensions of 1920x1080 pixels (508x285 millimeters).

Metadata Update from @jflory7:
- Pull-request untagged with: needs testing
- Pull-request tagged with: needs changes

Hi @anhpham, thanks for your changes! ๐Ÿ‘
I tested this with different mobile device settings successfully. However, for a larger screen I had this issue where the footer went off-screen:
Screenshot of page scrolled to farthest back corner to demonstrate bug
It looks like the footer pushed the rest of the page out further. Could you please debug this issue? I tested with screen dimensions of 1920x1080 pixels (508x285 millimeters).

For sure! I will take a look and test this more thoroughly. Thank you so much!

For sure! I will take a look and test this more thoroughly. Thank you so much!

No problem. :smiley: Thanks for working on this.

Also, it looks like your pull request fell has a merge conflict after some of the other open PRs were merged. I made this comment in another PR with some tips on keeping a local and remote branch in sync, in case this is useful for you too.

For sure! I will take a look and test this more thoroughly. Thank you so much!

No problem. ๐Ÿ˜ƒ Thanks for working on this.
Also, it looks like your pull request fell has a merge conflict after some of the other open PRs were merged. I made this comment in another PR with some tips on keeping a local and remote branch in sync, in case this is useful for you too.

Indeed it is very helpful for me thank you! I will try this and update you my progress ๐Ÿ‘

Metadata Update from @jflory7:
- Request assigned

Pull-Request has been closed by anhpham