#122 Styling the expandable side menu
Closed: out of scope by jflory7. Opened by richa208.

Currently there is extra space present on the right side of content to accommodate the expandable side menu.
In order to maintain the orientation, we can style the side menu so that there is no extra space present on original page and while expanding the menu, the original content adjusts(shrink) itself making room for the menu.


If the issue is appropriate, I would like to work on this.

@richa208 I don't understand this change. Could you post an annotated screenshot to show what you mean?

Metadata Update from @jflory7:
- Issue priority set to: needs review (was: awaiting triage)
- Issue tagged with: improvement, needs info, type - frontend, type - summer coding

fed.gif

pizap.com15513289913631.jpg

@jflory7 The marked space is present to accommodate the side bar on expanding.
So this issue is basically a front end modification where instead of leaving space for side menu, we can remove the space marked and slide the content to the left whenever side menu is expanded.

phoenixabhishek commented

@richa208 the side menu is a part of the development environment only and is not taken forward to production.
Also, we are a fork of mxsasha/happinesspackets and we mostly follow the same design cues as them.

This space occurs due to the use of col-md-10 class of bootstrap that is used.
This prevents the contents from going edge-to-edge on the user screen and display all content in a suitable viewing area while still leaving some breathing space for the page.

I'll let @jflory7 take this up and decide on how to proceed. :smile: :smile: :smile: :smile: :smile:

@richa208 you can correct this by changing the 'col-md-10' class to 'col-md-12' class, ( you can try this in your browser developer tools). But I think the narrow margins or the edge to edge design is best for mobile devices. and bootstrap automatically handles this.But Still, let @jflory7 take this issue and decide which one to use 'col-md-10' or 'col-md-12'.

I also agree with you @phoenixabhishek regarding this.

Hi,
@phoenixabhishek I didn't know that the menu is only a part of development environment. Also I agree with you that col-md-10 leaves some breathing space in the page but I thought of making it symmetrical (just my opinion) so raised this issue.
@shivamgoyal Yes, we can change it by using col-md-12 but then the side menu would be appearing on the text on expansion so we'll need to add some functionality over there in this case.
Thank you both of you for providing suggestions regarding this and lets wait for @jflory7 to take some decision.

Hi @richa208, I understand what you mean now. As others said, this is a developer toolbar that only appears in testing. Everyday users of the site won't see the developer toolbar.

Since we don't expect there to be anything there normally, I think it's okay to stick to upstream's implementation. In this case, I think it's better to follow upstream to keep our changes in our fork limited. In this case, I am going to close this issue as out of scope.

Thanks for opening this for discussion either way. :smiley:

Metadata Update from @jflory7:
- Issue close_status updated to: out of scope
- Issue status updated to: Closed (was: Open)

Metadata Update from @jflory7:
- Issue untagged with: needs info

Metadata