fedora-ci / simple-koji-ci

#3 Let simple-koji-ci use a custom mock config using nspawn with networking
Merged by pingou. Opened by pingou.
nspawn  into  master

Download 3.patch

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

1 new commit added

  • Small style fix

@clime this is the second part we talked about :)

I think, here should either be /etc/mock/simple_koji_ci.cfg or the config should be copied into the current working directory for the command.

The init call at https://pagure.io/fedora-ci/simple-koji-ci/blob/nspawn/f/simple_koji_ci/buildsys.py#_151 should probably also use the simple_koji_ci.cfg. (Or possibly it can be also dropped).

What do you think is best? Adjusting it or dropping it?

What do you think is best? Adjusting it or dropping it?

Probly I would drop it. 

commands.init(prebuild=not config_opts.get('short_circuit'))

is called for each srpm being rebuilt with mock --rebuild.

What do you think is best? Adjusting it or dropping it?

Probly I would drop it.
commands.init(prebuild=not config_opts.get('short_circuit'))

is called for each srpm being rebuilt with mock --rebuild.

For mock --buildsrpm (which is actually what we call here and not mock --rebuild) it should be the same.

mock --init dropped and I passed the full path to the config file :)

2 new commits added

  • Pass the full path to the custom mock config when building the srpm
  • Drop the call to mock --init, --buildsrpm does it by default

LGTM.

Thanks!

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.