#3 Add new card designs and upgrade argument parsing
Merged by bex. Opened by bex.
Unknown source master

Download 3.patch

Finally implement the replacement horizontal and new vertical
designs by @mleonova

https://pagure.io/design/issue/531

Note: This adds SVG templates which we do text replacement on
this has the side effect of making new cards easier

This also moves from optparse to argparse

@pviktori thank you for considering looking at this - any comments appreciated.

And yes - this is a mixed commit

[throwaway@f30-devbox-server ~]$ fedora-business-cards --list-generators
usage: fedora-business-cards [-h] [--list-generators] [--height HEIGHT]
                             [--width WIDTH] [--bleed BLEED] [--inch] [--mm]
                             [-d DPI] [--pdf] [--png] [--svg] [--eps]
                             [--cmyk-pdf]
                             GENERATOR ...
fedora-business-cards: error: the following arguments are required: GENERATOR

I get this error while trying to list generators available.

rebased onto 3a3cee3d317087340c14f15fa90d53ffec4a616e

@sayanchowdhury thanks for the catch! should be fixed here https://koji.fedoraproject.org/koji/taskinfo?taskID=37644989

Works for me! :100:

There's a lot of duplicate logic, but the change looks OK to me!

Sorry for the delay; there was work to take care of.

@pviktori thank you for the feedback. I agree that this can probably be deduplicated - but being done now was important to me :)

PRs welcome from anyone, not just you :)

TY again @sayanchowdhury

Pull-Request has been merged by bex

Metadata