#2671 Access banner validation
Closed: fixed Opened by mharmsen.

Application should accept Banner.txt only when file type is UTF-8 Unicode text
and ASCII text

Steps to Reproduce:

1.move the content of binary file into banner.txt
2.run pki command

Actual results:

error occurs as below
root@server6 ~ # pki -d /root/multihost_tests/certdb/ -c Secret123 -h
pki1.example.com -p 20080 -n "PKI CA Administrator for Example.Org" user-del
tuser1
JAXBUnmarshalException: javax.xml.bind.UnmarshalException
- with linked exception:
[org.xml.sax.SAXParseException; lineNumber: 1; columnNumber: 83; An invalid XML
character (Unicode: 0x3) was found in the element content of the document.]

Expected results:

file type can be determined and only ASCII and UTF-8 can be allowed.
root@pki1 ~ # file /etc/pki/pki-tomcat/banner.txt
/etc/pki/pki-tomcat/banner.txt: UTF-8 Unicode text, with very long lines
root@pki1 ~ # file /etc/pki/pki-tomcat/banner.txt
/etc/pki/pki-tomcat/banner.txt: ASCII text

Metadata Update from @mharmsen:
- Issue assigned to mharmsen

Metadata Update from @mharmsen:
- Custom field component adjusted to General
- Custom field feature adjusted to ''
- Custom field origin adjusted to Community
- Custom field proposedmilestone adjusted to ''
- Custom field proposedpriority adjusted to ''
- Custom field reviewer adjusted to ''
- Custom field rhbz adjusted to https://bugzilla.redhat.com/show_bug.cgi?id=1446579
- Custom field type adjusted to defect
- Custom field version adjusted to ''
- Issue assigned to edewata (was: mharmsen)

Metadata Update from @mharmsen:
- Issue priority set to: critical

Metadata Update from @edewata:
- Issue priority set to: major (was: critical)

Fixed in master:

  • https://github.com/dogtagpki/pki/commit/d2e247798a36225880ef6050716cc7576fe2ad7f
  • https://github.com/dogtagpki/pki/commit/4a8e1703603ab348b24d4f010e3587c340e1a032
  • https://github.com/dogtagpki/pki/commit/e5f6ed7be301a3531b871ef3b0ce64bea0fe1973
  • https://github.com/dogtagpki/pki/commit/5e0dcb69a734c9f52cca673a7a5189d31fb15774
  • https://github.com/dogtagpki/pki/commit/691edcc397d6d93d14c67d23f925e32916986a55
  • https://github.com/dogtagpki/pki/commit/22e97396e3f5e5024b4fee3f816ca319857126df
  • https://github.com/dogtagpki/pki/commit/bd82be4999b066bdf2fd91683432de6f7bdcf667
  • https://github.com/dogtagpki/pki/commit/78f61f5baa5301f8fee03210a19514b36100e266
  • https://github.com/dogtagpki/pki/commit/9db838825b60719e6670c92957db3f33c5b12ae0

Metadata Update from @edewata:
- Issue close_status updated to: fixed
- Issue set to the milestone: 10.4.9 (was: 10.4)
- Issue status updated to: Closed (was: Open)

Additional changes:

  • master: https://github.com/dogtagpki/pki/commit/5a643b07976e348dcba19c34d75886174666d665
  • 10.4: https://github.com/dogtagpki/pki/commit/889a9c9efce62488f098fb96fcf4a1454c0b3bc2

Dogtag PKI is moving from Pagure issues to GitHub issues. This means that existing or new
issues will be reported and tracked through Dogtag PKI's GitHub Issue tracker.

This issue has been cloned to GitHub and is available here:
https://github.com/dogtagpki/pki/issues/2791

If you want to receive further updates on the issue, please navigate to the
GitHub issue and click on Subscribe button.

Thank you for understanding, and we apologize for any inconvenience.

Metadata