PR Guidelines

Keep writing

Provided a clear statement of the changes that are included in the PR. This will help the right people see your changes and will aid in getting them looked at faster.

Keep it small

Giant dumps or edits make reviews a lengthy and time consuming process. For the sake of the review, and yourself keep PRs as small as you can while still making sense. If you are providing a large amount of edit to existing documents attempt to group them by section, or by the type of correction you are making. If you are adding new content keep limit each PR to a new page or section.

Keep it clean

Histories are an extremely valuable part of using a version control system, but providing a history of your small changes may not be as useful. If you are the type of person who commits often locally, and tend to have lots of commits making up your PR look at using git rebase to combine commits into a smaller number of more verbose commits.

Keep paying attention

As the PR submitter your job is not done once you start the process. Make sure to stay engaged and work with the people reviewing your changes.

Keep a good attitude

After putting a lot of work into something, it is natural to take reviews as a personal attack. Try and remember that this process is designed to help create the best possible end product for Fedora. It is important to keep that in mind and not to let it discourage you from continuing on.