SSSD / sssd

#4153 Few fixes in configure script
Merged by pbrezina. Opened by lslebodn.
SSSD/ lslebodn/sssd config_fixes  into  master

Download 4153.patch
  • Fix detection of attribute fallthrough
      configure:27218: checking whether compiler supports __attribute__((fallthrough))
      configure:27228: gcc -c -Werror  conftest.c >&5
      conftest.c:185:2: error: 'fallthrough' attribute at top level [-Werror=attributes]
        185 |  __attribute__ ((fallthrough));
            |  ^~~~~~~~~~~~~
      cc1: all warnings being treated as errors
  • Fix detection of samba version for idmap plugin

The parameter -e is not standard parameter for echo builtin.
And therefore needn't be implemented in some shells.

e.g.

      sh$ /bin/dash -c 'echo -e "#include <samba/version.h>\nSAMBA_VERSION_MAJOR"'
      -e #include <samba/version.h>
      SAMBA_VERSION_MAJOR

And it caused failures in configure

      checking Samba's idmap plugin interface version... idmap test result is: 6
      configure: Samba's idmap interface version: 6
      configure: Samba version: -e #include <samba/version.h>
      SAMBA_VERSION_MAJOR -e #include <samba/version.h>
      SAMBA_VERSION_MINOR -e #include <samba/version.h>
      SAMBA_VERSION_RELEASE
      /home/build/sssd/configure: 21832: test: #include: unexpected operator
      configure: Samba's struct idmap_domain does not have dom_sid member

rebased onto 4ebfc00c460c08a0fd3eb5d609bdf0c1ec123ea4

Metadata Update from @pbrezina:
- Request assigned

Thank you. I wanted to write similar patch for rawhide. It detects the attribute correctly now.

Ack.

Commit a483bfa6 fixes this pull-request

Pull-Request has been merged by pbrezina

Commit c3b98b2b fixes this pull-request

Pull-Request has been merged by pbrezina
  • master
    • c3b98b2b6703f72012f1ecfadede96eaaef52a48 - CONFIGURE: Fix detection of samba version for idmap plugin
    • a483bfa67aa9ec67b1a87848184567d8c7acd174 - CONFIGURE: Fix detection of attribute fallthrough
Metadata
pbrezina
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.