#4075 BUILD: Prefer python3 for intgcheck
Closed by pbrezina. Opened by lslebodn.
SSSD/ lslebodn/sssd intg_py3  into  master

Download 4075.patch

Samba 4.11.0 dropped support for python3 and thus it was also
dropped from samba related libraries (ldb ...)
which is required by integration tests

Resolves:
https://pagure.io/SSSD/sssd/issue/4074

9 new commits added

  • intg: Install python3 dependencies for intgcheck on new distros
  • BUILD: Prefer python3 for intgcheck
  • INTG: Do hot hardcode version of python/pytest in intgcheck
  • BUILD: Move python checks for intgcheck to macro
  • BUILD: Change value of variable HAVE_PYTHON2/3_BINDINGS
  • BUILD: Add macro for checking pytest for intgcheck
  • BUILD: Move checking of python2 modules for intgcheck
  • BUILD: Fix typo of detecting python module for intgcheck
  • BUILD: Add macro for checking python3 modules

Thank you.

Samba 4.11.0 dropped support for python3 and thus it was also
dropped from samba related libraries (ldb ...)
which is required by integration tests

I guess it should say python2. Otherwise it looks good to me. I will run some test before acking.

I change the commit message so it says that python2 was dropped instead of python3 and I'm going to push the patches. CI passed on all systems.

Commit 5dc86be0 fixes this pull-request

Pull-Request has been merged by pbrezina

Commit 0e1346b9 fixes this pull-request

Pull-Request has been merged by pbrezina

  • master
    • e613dd34bd26c6ab32186c7393177de41c5ef628 - intg: Install python3 dependencies for intgcheck on new distros
    • d30904d898c46613aac97eecf43c84bdea3cd278 - BUILD: Prefer python3 for intgcheck
    • 5be4ebf9c92bb5e305c52bc89c6c7f62bfe8d81d - INTG: Do hot hardcode version of python/pytest in intgcheck
    • a34ea677d9eb5e829d207bb9aae7520f7a3533ac - BUILD: Move python checks for intgcheck to macro
    • 69832d49b627d7237bc3ce449e0930c25fa17eef - BUILD: Change value of variable HAVE_PYTHON2/3_BINDINGS
    • 784b17bef1d68f7bcc51ae80bcd31edfb4ed384f - BUILD: Add macro for checking pytest for intgcheck
    • fd0e08fce33b5119c400f322c6227c527093d4ce - BUILD: Move checking of python2 modules for intgcheck
    • fbd9c987699349c951c380a88381dce4962856ed - BUILD: Fix typo of detecting python module for intgcheck
    • 768c295b5c35fca5964ea17e030c2a2fbce2b816 - BUILD: Add macro for checking python3 modules

Pull-Request has been closed by pbrezina

I change the commit message so it says that python2 was dropped instead of python3 and I'm going to push the patches. CI passed on all systems.

Thank you very much for fixing typo. (sorry, I was busy with other tasks yesterday).
BTW it should have not been necessary to close PR.
I added comment to few commit

 Merges: https://pagure.io/SSSD/sssd/pull-request/4075

And you can see even messages in this PR that it was merged.
If PR was not automatically marked as merged than there is a bug in pagure :-)

Metadata