#3953 Do not uses pytest fixtures as functions
Merged by jhrozek. Opened by lslebodn.
SSSD/ lslebodn/sssd RemovedInPytest4Warning  into  master

Download 3953.patch

test_ldap.py::test_local_negative_timeout_enabled_by_default
/usr/lib/python3.7/site-packages/_pytest/fixtures.py:827:
RemovedInPytest4Warning: Fixture "passwd_ops_setup" called directly.
Fixtures are not meant to be called directly, are created
automatically when test functions request them as parameters. See
https://docs.pytest.org/en/latest/fixture.html for more information.
res = fixturefunc(kwargs)
/usr/lib/python3.7/site-packages/_pytest/fixtures.py:827:
RemovedInPytest4Warning: Fixture "group_ops_setup" called directly.
Fixtures are not meant to be called directly, are created
automatically when test functions request them as parameters. See
https://docs.pytest.org/en/latest/fixture.html for more information.
res = fixturefunc(
kwargs)
/usr/lib/python3.7/site-packages/_pytest/fixtures.py:827:
RemovedInPytest4Warning: Fixture "user_and_group_rfc2307" called directly.
Fixtures are not meant to be called directly, are created
automatically when test functions request them as parameters. See
https://docs.pytest.org/en/latest/fixture.html for more information.

test_files_provider.py::test_getpwnam_after_start
  src/tests/intg/test_files_provider.py:344: RemovedInPytest4Warning:
    Fixture "passwd_ops_setup" called directly. Fixtures are not meant
    to be called directly, are created automatically when test functions
    request them as parameters.
    See https://docs.pytest.org/en/latest/fixture.html for more information.
  src/tests/intg/test_files_provider.py:362: RemovedInPytest4Warning:
    Fixture "group_ops_setup" called directly. Fixtures are not meant
    to be called directly, are created automatically when test functions
    request them as parameters.
    See https://docs.pytest.org/en/latest/fixture.html for more information.
      return setup_gr_with_list(request, [GROUP1, CANARY_GR])

Resolves:
https://pagure.io/SSSD/sssd/issue/3942

LGTM, will ack if CI passes

Commit 948cd08c fixes this pull-request

Pull-Request has been merged by jhrozek

Commit 686a8f5f fixes this pull-request

Pull-Request has been merged by jhrozek

  • master:
  • 686a8f5f1de8447aedd3c65715ff40118bb9908f
  • 948cd08cd91cda79f6afa96f99241f26d84bf1bc
  • sssd-1-16:
  • 28051216703d7045b044619b366c691e8fec7c8d
  • 0fb6543ecf9f6169a0289c2c73e113fee26e25f2
Metadata