#3853 p11_child: Fix warnings may be used uninitialized
Closed by sbose. Opened by lslebodn.
SSSD/ lslebodn/sssd p11_child_uninit2  into  master

Download 3853.patch

The variable modules can be uninitialized in done section in case of
failure p11_kit_uri_parse(uri_str, P11_KIT_URI_FOR_ANY, uri).

And compiler can expect the variable "s" to be uninitialized in case of
always matching condition for "Skip modules which do not match the PKCS#11 URI"

src/p11_child/p11_child_openssl.c: In function ‘do_card’:
src/p11_child/p11_child_openssl.c:1046:5: error: ‘modules’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
p11_kit_modules_finalize_and_release(modules);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/p11_child/p11_child_openssl.c:830:20: error: ‘s’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
slot_id = slots[s];
~~~~~^~~
Merges: https://pagure.io/SSSD/sssd/pull-request/3853

This fix was already send earlier in https://github.com/SSSD/sssd/pull/675. So I close this one.

Pull-Request has been closed by sbose

Metadata