PR#3792: CRYPTO: Save prefix in s3crypt_sha512 -

SSSD / sssd

#3792 CRYPTO: Save prefix in s3crypt_sha512

Merged Aug 2, 2018 by jhrozek. Opened Jul 31, 2018 by lslebodn.

SSSD/ lslebodn/sssd s3_crypt into master

lslebodn commented Jul 31, 2018

Since commit 2951a9a84bd85f384213a3e071ffc167907df2d7 where we switched from
stpncpy to memcpy the salt prefix "$6$" is not stored at all.
This broke offline authentication if someone upgraded from old version
that stored the prefix to one that doesn't store it.

Resolves:
https://pagure.io/SSSD/sssd/issue/3791

rebased onto 131242faf655f3a6325406c9eb2546cfdebf13ab

Jul 31, 2018

jhrozek commented Aug 1, 2018

Hey @mzidek can you review?

jhrozek commented Aug 2, 2018

mzidek is on vacation. But the patch is easy enough and it's another approach we considered. ACK.

jhrozek commented Aug 2, 2018

(Running CI and Coverity before pushing)

jhrozek commented Aug 2, 2018

Commit 8e1576b1 fixes this pull-request

Pull-Request has been merged by jhrozek