From 3c5d4a836a523a03a90bc125ebef93a0608ea57c Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Jul 21 2018 21:27:47 +0000 Subject: PYTHON: Avoid warnings with python3.7 src/python/pysss.c: In function 'PyList_AsStringList': src/python/pysss.c:60:17: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] itemstr = PyUnicode_AsUTF8AndSize(item, &itemlen); ^ src/python/pyhbac.c: In function 'str_concat_sequence': src/python/pyhbac.c:252:14: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] part = PyUnicode_AsUTF8(item); ^ The result of PyUnicode_AsUTF8AndSize() and PyUnicode_AsUTF8() is now of type const char * rather of char *. (Contributed by Serhiy Storchaka in bpo-28769.) https://docs.python.org/3.7/whatsnew/3.7.html https://bugs.python.org/issue28769 Merges: https://pagure.io/SSSD/sssd/pull-request/3780 --- diff --git a/src/python/pyhbac.c b/src/python/pyhbac.c index f7633ee..d78452c 100644 --- a/src/python/pyhbac.c +++ b/src/python/pyhbac.c @@ -232,7 +232,7 @@ str_concat_sequence(PyObject *seq, const char *delim) Py_ssize_t i; PyObject *item; char *s = NULL; - char *part; + const char *part; size = PySequence_Size(seq); diff --git a/src/python/pysss.c b/src/python/pysss.c index 16c086a..cdabe9c 100644 --- a/src/python/pysss.c +++ b/src/python/pysss.c @@ -45,7 +45,7 @@ static char **PyList_AsStringList(TALLOC_CTX *mem_ctx, PyObject *list, ret = talloc_array(mem_ctx, char *, PyList_Size(list)+1); for (i = 0; i < PyList_Size(list); i++) { - char *itemstr; + const char *itemstr; Py_ssize_t itemlen; PyObject *item = PyList_GetItem(list, i); #ifdef IS_PY3K