SSSD / sssd

#3732 Fix few bugs in selinux child
Merged by jhrozek. Opened by lslebodn.
SSSD/ lslebodn/sssd selinux_child  into  master

Download 3732.patch
no initial comment

rebased onto 9a9bfd2d94f261fd468ae20a93d862ddaf80ae88

ACK to both.

And I'm sorry it took me so long to get to the review.

Actually it's good that I at least compile patches before pushing :)

/home/remote/jhrozek/devel/sssd/src/util/sss_semanage.c: In function ‘sss_set_seuser’:
/home/remote/jhrozek/devel/sssd/src/util/sss_semanage.c:344:21: error: expected ‘)’ before ‘{’ token
     if (key != NULL {
                     ^
/home/remote/jhrozek/devel/sssd/src/util/sss_semanage.c:349:1: error: expected expression before ‘}’ token
 }
 ^
/home/remote/jhrozek/devel/sssd/src/util/sss_semanage.c:349:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
make[2]: *** [Makefile:25820: src/util/selinux_child-sss_semanage.o] Error 1
make[2]: *** Waiting for unfinished jobs....
/home/remote/jhrozek/devel/sssd/src/util/sss_semanage.c: In function ‘sss_set_seuser’:
/home/remote/jhrozek/devel/sssd/src/util/sss_semanage.c:344:21: error: expected ‘)’ before ‘{’ token
     if (key != NULL {
                     ^
/home/remote/jhrozek/devel/sssd/src/util/sss_semanage.c:349:1: error: expected expression before ‘}’ token
 }
 ^
/home/remote/jhrozek/devel/sssd/src/util/sss_semanage.c:349:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^

Let me know if you want to fix this or if I should.

Commit 51c6c483 fixes this pull-request

Pull-Request has been merged by jhrozek

Commit 92addd7b fixes this pull-request

Pull-Request has been merged by jhrozek

I fixed the typo and pushed the patches; thank you very much for the contribution
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.