SSSD / sssd

#3699 UTIL: Use alternative way for detecting PyErr_NewExceptionWithDoc
Closed by jhrozek. Opened by lslebodn.
SSSD/ lslebodn/sssd configure_python  into  master

Download 3699.patch

Function PyErr_NewExceptionWithDoc was added in python 2.7.0
and we use fallback implementation for older versions of python.

Previously, we used detection of PyErr_NewExceptionWithDoc at configure
time; but it does not work well in case of python2.6 and python3.x

Resolves:
https://pagure.io/SSSD/sssd/issue/3656

@sbose, I know you preferred detection at configure time[1] but this version was much simpler and more lines are removed then added. And PY_VERSION_HEX is already used in sssd on other place

[1] https://pagure.io/SSSD/sssd/issue/3653#comment-497100

Given the alternative of having two different variables, one for each python version, I agree that checking PY_VERSION_HEX is more straight forward.

I'll wait for the CI blessing before giving my ack.

CI passed http://vm/logs/job/87/96/summary.html

ACK
  • master:
    f0bcadfb033c78c78631c4430288a60aa639100f
    810935f67a25f130b37f72948cc9a8b37529afc1

Pull-Request has been closed by jhrozek
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.