PR#3611: Fix minor spelling mistakes; fix formatting -

SSSD / sssd

#3611 Fix minor spelling mistakes; fix formatting

Merged Feb 13, 2018 by lslebodn. Opened Dec 21, 2017 by sobek.

SSSD/ sobek/sssd fix-spelling into master

sobek commented Dec 21, 2017

In:
src/tests/python/README.rst
src/tests/python/docs/running.rst
src/tests/python/docs/Install.rst
src/tests/python/docs/layout.rst

the formatting has been changed.

Below are questions that I cannot find an answer for. I need your guidance.

In:
src/tests/python/docs/examples.rst
src/tests/python/docs/running.rst

the mentioned repo (git://git.app.eng.bos.redhat.com/sssd-qe-tests.git) is not accessible. What to do?

In:
src/monitor/monitor.c

I am not sure whether ' warning' is a formatting issue, i.e. can " " be deleted or not?
The sentence is:
* As a result of this * warning is printed ‘monitor’ may be used$
* uninitialized in this function.

In:
src/providers/ldap/sdap_async_nested_groups.c

code has been changed:
deref_treshold
--
deref_threshold

Is this used by external code?
If so, where do I have to push a patch?

In:
src/providers/proxy/proxy_id.c

same for:
remove_duplicit_group_members(...
--
remove_duplicate_group_members(...

In:
src/responder/pam/pamsrv.c

same for:
ALL_DOMAIMS_ARE_PUBLIC
NO_DOMAIMS_ARE_PUBLIC
--
ALL_DOMAINS_ARE_PUBLIC
NO_DOMAINS_ARE_PUBLIC

rebased onto a66770256c599530733ee5e1fed05e10aa5dbc18

Dec 21, 2017

lslebodn commented Jan 12, 2018

Please Do not edit *.pot files. They are generated from xml files. And you already fixed that in src/man/sss-certmap.5.xml

lslebodn commented Jan 12, 2018

Could you split this huge change into more patches?
At least separate patch for changes in src/tests/multihost/, src/tests/python/. Please there separate commit for rst and for py files.

rebased onto 834d0c20198e2652d843f1700a27b7071aac934b

Jan 14, 2018

sobek commented Jan 14, 2018

I am sorry for the *.pot file editing. I have removed it.
The changes have been distributed into multiple patches.

lslebodn commented Jan 29, 2018

Thank you very much for splitting to more patches.
BTW it seems that we do copy&paste very often or we subconsciously do the same mistakes :-)

master:

49dd8ee2834d9477418961dbaffa4a03cfa9fd1e
346d6d8bf5fdb446921d754c07c8a7d913a048d5
57c5ea8825c7179fd93382dbcbb07e828e5aec19
080e1bfb72ed0e8d96e390d83ad35eaba79bd450
677a31351c80453d9ce006481364399a96312052
4a9c1047354dbe5a4ed41e5951ae623e3772e113

Statistic for pushed patches:
167 files changed, 537 insertions(+), 536 deletions(-)

Edited Jan 29, 2018 by lslebodn

lslebodn commented Jan 29, 2018

I did not push following patches:

Fix minor spelling mistakes and formatting in tests/python/*
Fix minor spelling mistakes in PY files in tests/python/*
Fix minor spelling mistakes in tests/multihost/*

@sobek, could you rebase/cherry-pick them on top of current master?

I would prefer if original author do the review.

sobek commented Jan 30, 2018

@lslebodn no problem, I am fine with it; I rebased using these commands:
$ cd sssd
$ git checkout fix-spelling
$ git remote update
$ git rebase
...
CONFLICT (content): Merge conflict in src/providers/krb5/krb5_child.c
...
$ vim src/providers/krb5/krb5_child.c
( I removed lines from my fork to match origin's master )
$ git add src/providers/krb5/krb5_child.c
$ git rebase # says 'No changes', so skipping it
$ git rebase --skip
Applying: Fix minor spelling mistakes in tests/multihost/
Applying: Fix minor spelling mistakes in PY files in tests/python/
Applying: Fix minor spelling mistakes and formatting in tests/python/*
$ git push myfork --force