SSSD / sssd

#936 Incorrect NULL check in ipa_hbac_common.c
Closed: Fixed Opened by sgallagh.

Closed: Fixed
Reopen Issue

From Coverity scan:

 538    tmp_ctx = talloc_new(mem_ctx);
CID 10890: Logically dead code (DEADCODE)After this line (or expression), the value of "tmp_ctx" cannot be 0.
 539    if (tmp_ctx == NULL) return ENOMEM;
 540
 541    eval_req = talloc_zero(tmp_ctx, struct hbac_eval_req);
On this path, the condition "tmp_ctx == NULL" cannot be true.
 542    if (tmp_ctx == NULL) {
Execution cannot reach this statement "ret = 12;".
 543        ret = ENOMEM;
 544        goto done;
 545    }

The NULL check should be of eval_req, not tmp_ctx there.

Fixed by 1ea2e8bd370e0dc2f2c3fa09232cf67082ef748d

resolution: => fixed
status: new => closed

Backported to sssd-1-5

341ed34955270f7b360ab9453dee79d37b891857

milestone: SSSD 1.6.0 => SSSD 1.5.12

Fields changed

rhbz: => 0

Metadata Update from @sgallagh:
- Issue assigned to sgallagh
- Issue set to the milestone: SSSD 1.5.12

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/1978

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.
Metadata
None
None
None
Normal
defect
IPA Provider
0
0
0
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.