SSSD / sssd

#763 sss_obfuscate/python config parser modifies config file too much
Closed: Fixed Opened by sbose.

Closed: Fixed
Reopen Issue

When calling sss_obfuscate with the following simplified config file:

; comment
[sssd]
config_file_version = 2
[domain/ABC]
id_provider = ldap
; trailing comment

to following is returned:

# comment
[sssd]
config_file_version = 2
domains = 
[domain/ABC]
cache_credentials = False
ldap_default_authtok_type = obfuscated_password
id_provider = ldap
ldap_id_use_start_tls = False
debug_level = 0
ldap_schema = rfc2307
ldap_default_authtok = AAAQAE0p7C2dwEkkvfhfsYO3h7E5avTltddh8+1sPi61Ff1tyHWJll0xoMaIrLjlz5WQ/k44UA1lns9I8K+hxYJIvJQAAQIDAAA=

As sss_obfuscate changes the config file more than just adding ldap_default_authtok_type and ldap_default_authtok it should save a copy of the original file.

I see the following issues with the additional changes:
- trailing comments are remove
- according to sssd.conf(5) '#' and ';' are valid signs for comments, so it would be nice if both are preserved respectively
- adding default values for options which where not in the original file might lead to a config file less readable
- an explicit 'debug_level = 0' overwrites the debug level given at the sssd command line, so it shouldn't be written to the new config file

I opened ticket #764 to address the debug_level issue. The command-line should always override the option set in sssd.conf.

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.6.0
upgrade: => 0

Fields changed

priority: major => trivial

Fields changed

owner: somebody => jzeleny

Fields changed

status: new => assigned

Fixed by 0e5879c0e3f83b0bbaff79d9c97f672055b61c4f

patch: => 0
resolution: => fixed
status: assigned => closed

Ticket has been cloned to Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=785879

rhbz: => [https://bugzilla.redhat.com/show_bug.cgi?id=785879 785879]

Metadata Update from @sbose:
- Issue assigned to jzeleny
- Issue set to the milestone: SSSD 1.6.0

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/1805

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.
Metadata
None
None
None
Highest
defect
SSSDConfig API
1.5.0
None
0
None
0
https://bugzilla.redhat.com/show_bug.cgi?id=785879
defect
SSSDConfig API
1.5.0
None
0
None
0
https://bugzilla.redhat.com/show_bug.cgi?id=785879
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.