#715 Improper bit manipulation in pam_sss
Closed: Fixed Opened by sgallagh.

In "1 << 0", shifting "1" does not change its logical value (of 1/true) [logical operand of '!'].
 1509            flags &= !FLAGS_USE_FIRST_PASS;
 1510            ret = pam_set_item(pamh, PAM_AUTHTOK, NULL);

Related to

   55#define FLAGS_USE_FIRST_PASS (1 << 0)
   56#define FLAGS_FORWARD_PASS   (1 << 1)
   57#define FLAGS_USE_AUTHTOK    (1 << 2)

Fields changed

keywords: => Coverity

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.5.1

Fixed by e404ac6b8c5b78a102e20320133706f5efa66b12

coverity: => 10006
milestone: SSSD 1.5.1 => SSSD 1.5.0
resolution: => fixed
status: new => closed

Fields changed

coverity: 10006 => 10006, 10026

Fields changed

rhbz: => 0

Metadata Update from @sgallagh:
- Issue assigned to sbose
- Issue set to the milestone: SSSD 1.5.0

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/1757

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata